Attention is currently required from: Tarun Tuli, Eran Mitrani, Subrata Banik, Kapil Porwal.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66919 )
Change subject: mb/google/rex: Add audio parts ALC5682I-VD and MAX9835
......................................................................
Patch Set 19:
(1 comment)
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/66919/comment/71164f66_e6064396
PS19, Line 210: 10EC5682
Hi Eran,
I cherry-pick your CL to try , it shows `rt5682 i2c-10EC5682:00: Device with ID register 6749 is not rt5682` and I have confirmed with EE , Rex use ALC5682I-VS. need use `RTL5682` for ALC5682I-VS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia8dfc79e7e4d27828726145156c870733d716899
Gerrit-Change-Number: 66919
Gerrit-PatchSet: 19
Gerrit-Owner: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ivy Jian
ivy.jian@quanta.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Mon, 05 Sep 2022 09:54:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment