Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30014 )
Change subject: drivers/spi/winbond: Fix TB bit ......................................................................
drivers/spi/winbond: Fix TB bit
The TB has to be inverted to actually protected the correct region.
Tested on elgon using I67eb4ee8e0ad297a8d1984d55102146688c291fc.
Change-Id: I715791b8ae5d1db1ef587321ae5c9daa10eb7dbc Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/30014 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-by: David Hendricks david.hendricks@gmail.com Reviewed-by: Julius Werner jwerner@chromium.org --- M src/drivers/spi/winbond.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Philipp Deppenwiese: Looks good to me, approved Julius Werner: Looks good to me, approved
diff --git a/src/drivers/spi/winbond.c b/src/drivers/spi/winbond.c index 9eb3352..f8ea247 100644 --- a/src/drivers/spi/winbond.c +++ b/src/drivers/spi/winbond.c @@ -303,7 +303,7 @@ tb = !tb; }
- out->offset = tb ? flash_size - protected_size : 0; + out->offset = tb ? 0 : flash_size - protected_size; out->size = protected_size; }
@@ -519,9 +519,9 @@ wp_region = *region;
if (region_offset(&wp_region) == 0) - tb = 0; - else tb = 1; + else + tb = 0;
if (region_sz(&wp_region) > flash->size / 2) { cmp = 1;