Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55732 )
Change subject: soc/amd/cezanne: Init eSPI early if required ......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/bootblock.c:
https://review.coreboot.org/c/coreboot/+/55732/comment/b9685689_b0440052 PS2, Line 99: if (CONFIG(NO_EARLY_BOOTBLOCK_POSTCODES))
Am I reading the condition correctly? I believe we should setup port 80 as early as possible if post […]
If the system needs NO_EARLY_BOOTBLOCK_POSTCODES, and it's not enabled, we won't even reach this point, because it will hang in the asm.
If there's a need to disable early postcodes, we need to enable it as early as possible. If we don't enable NO_EARLY_BOOTBLOCK_POSTCODES (ie. if there's no possibility of a hang), then we can enable eSPI later when we have the console up.
Basically the idea is that this would be turned on if psp_verstage is not enabled.
-
Martin Roth (Code Review)