[XS] Change in coreboot[main]: driver/intel/fsp2_0: Prevent error logs during S3 wakeup

[Varun Upadhyay (Code Review)]

Attention is currently required from: Andrey Petrov, Krishna P Bhat D, Ronak Kanabar, Subrata Banik.

Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/83055?usp=email )

Change subject: driver/intel/fsp2_0: Prevent error logs during S3 wakeup
......................................................................

Patch Set 3:

(2 comments)

File src/drivers/intel/fsp2_0/fsp_gop_blt.c:

https://review.coreboot.org/c/coreboot/+/83055/comment/967145d2_a8e957d0?usp... :
PS2, Line 245: 	/* CBMEM is locked for S3 resume path. */
             : 	if (acpi_is_wakeup_s3())
             : 		return;
> sorry, unable to follow, are you saying we don't need to draw FW splash screen while resuming from S […]

The current implementation returns NULL from bmp_load_logo() when the system is waking up from an S3 sleep state so it doesnt goes to draw FW Splash screen, This change is just eliminating error messages that were being logged during the S3 resume process.

File src/lib/bmp_logo.c:

https://review.coreboot.org/c/coreboot/+/83055/comment/ab3b3ac3_12f5866e?usp... :
PS2, Line 23: 	/* CBMEM is locked for S3 resume path. */
            : 	if (acpi_is_wakeup_s3())
            : 		return NULL;
            :
> please don't move this from here, There are users who can call bmp_load_logo() function independentl […]

Done