Change in coreboot[master]: [Not For Merge] nb/intel/i945: Remove unused #define REFRESH_* - coreboot-gerrit

27 Mar 2017


      HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/19016 )
Change subject: [Not For Merge] nb/intel/i945: Remove unused #define REFRESH_*
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
indeed, the refresh stuff is confused ...
https://review.coreboot.org/#/c/19016/1/src/northbridge/intel/i945/raminit.c
File src/northbridge/intel/i945/raminit.c:
PS1, Line 848: if (refresh == 2) {
             : 			sysinfo->refresh = 1;
regarding the datasheet JEDEC Standard No. 21-C, the value '2' is for Reduced (.5x) 7.8μs
so why we set it to one (Reduced (.25x) 3.9 μs)?
-- 
To view, visit https://review.coreboot.org/19016
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I70d5437face1a3ff4cacda4cb3f9a67d2ca4c403
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes