build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/26391 )
Change subject: intel/common: change mca_configure API's def ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/cpu/cpuli... File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/cpu/cpuli... PS2, Line 309: printk(BIOS_DEBUG, "CPU: mca_configure num banks %d\n", num_banks); Prefer using '"%s...", __func__' to using 'mca_configure', this function's name, in a string
https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/#/c/26391/2/src/soc/intel/common/block/include/i... PS2, Line 160: void mca_configure(void* unused); "foo* bar" should be "foo *bar"
-
build bot (Jenkins) (Code Review)