Julius Werner has posted comments on this change. ( https://review.coreboot.org/19769 )
Change subject: soc/nvidia/tegra*: Move spi driver to use spi_bus_map
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/19769/1/src/soc/nvidia/tegra124/spi.c
File src/soc/nvidia/tegra124/spi.c:
Line 800: return -1;
nit: This check seems to have always been pretty pointless. It'll never actually do anything, even if the bus number is wrong. I think you might as well take it (and the whole setup() function) out.
--
To view, visit
https://review.coreboot.org/19769
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I873b96d286655a814554bfd89f899ee87302b06d
Gerrit-PatchSet: 1
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-HasComments: Yes