[S] Change in libgfxinit[master]: hw-gfx-gma: Update BDSM register offset for TGL onwards - coreboot-gerrit

6 Oct 2022


      Attention is currently required from: Nico Huber, Angel Pons.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/65178 )
Change subject: hw-gfx-gma: Update BDSM register offset for TGL onwards
......................................................................
Patch Set 7:
(1 comment)
File common/hw-gfx-gma.adb:
https://review.coreboot.org/c/libgfxinit/+/65178/comment/4103401a_9053faf6 
PS6, Line 861: Dev.Read32
...
It's 64 bits now.
Ah ok I missed that. I can't seem to find public TGL datasheets yet 😞 maybe I missed them, I assume 0xc4 is the high 32 bits? For now we could just bail if there's anything set in the high bits.
-- 
To view, visit https://review.coreboot.org/c/libgfxinit/+/65178
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: libgfxinit
Gerrit-Branch: master
Gerrit-Change-Id: I0a3e7a92dcb08ea33e08c9f2c5135d4269c9e0b9
Gerrit-Change-Number: 65178
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Wawrzynczak inforichland@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 06 Oct 2022 01:38:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment