Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47001 )
Change subject: soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef ......................................................................
soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef
It is not used.
Change-Id: I3ef0878811bf2ec406ded03aac6c5dfeb5bf45a2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/pei_data.h M src/soc/intel/quark/include/soc/pei_wrapper.h 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/47001/1
diff --git a/src/soc/intel/broadwell/pei_data.h b/src/soc/intel/broadwell/pei_data.h index bc9f220..67d73d9 100644 --- a/src/soc/intel/broadwell/pei_data.h +++ b/src/soc/intel/broadwell/pei_data.h @@ -246,6 +246,4 @@ struct pei_memory_info meminfo; } __packed;
-typedef struct pei_data PEI_DATA; - #endif diff --git a/src/soc/intel/quark/include/soc/pei_wrapper.h b/src/soc/intel/quark/include/soc/pei_wrapper.h index a14da63..5c52d3b 100644 --- a/src/soc/intel/quark/include/soc/pei_wrapper.h +++ b/src/soc/intel/quark/include/soc/pei_wrapper.h @@ -28,6 +28,4 @@ int data_to_save_size; } __packed;
-typedef struct pei_data PEI_DATA; - #endif /* _PEI_WRAPPER_H_ */
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47001
to look at the new patch set (#5).
Change subject: soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef ......................................................................
soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef
It is not used.
Change-Id: I3ef0878811bf2ec406ded03aac6c5dfeb5bf45a2 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/broadwell/include/soc/pei_data.h M src/soc/intel/quark/include/soc/pei_wrapper.h 2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/47001/5
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47001 )
Change subject: soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef ......................................................................
Patch Set 5: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47001 )
Change subject: soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef ......................................................................
soc/intel/{broadwell,quark}: Drop `PEI_DATA` typedef
It is not used.
Change-Id: I3ef0878811bf2ec406ded03aac6c5dfeb5bf45a2 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47001 Reviewed-by: Frans Hendriks fhendriks@eltan.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/broadwell/include/soc/pei_data.h M src/soc/intel/quark/include/soc/pei_wrapper.h 2 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved
diff --git a/src/soc/intel/broadwell/include/soc/pei_data.h b/src/soc/intel/broadwell/include/soc/pei_data.h index bc9f220..67d73d9 100644 --- a/src/soc/intel/broadwell/include/soc/pei_data.h +++ b/src/soc/intel/broadwell/include/soc/pei_data.h @@ -246,6 +246,4 @@ struct pei_memory_info meminfo; } __packed;
-typedef struct pei_data PEI_DATA; - #endif diff --git a/src/soc/intel/quark/include/soc/pei_wrapper.h b/src/soc/intel/quark/include/soc/pei_wrapper.h index a14da63..5c52d3b 100644 --- a/src/soc/intel/quark/include/soc/pei_wrapper.h +++ b/src/soc/intel/quark/include/soc/pei_wrapper.h @@ -28,6 +28,4 @@ int data_to_save_size; } __packed;
-typedef struct pei_data PEI_DATA; - #endif /* _PEI_WRAPPER_H_ */
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Patrick Georgi (Code Review)