Attention is currently required from: Paul Menzel. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58343 )
Change subject: ec/starlabs: Add standardised ITE EC support ......................................................................
Patch Set 17:
(4 comments)
File src/ec/starlabs/merlin/ec.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132807): https://review.coreboot.org/c/coreboot/+/58343/comment/a0187599_76037bfb PS17, Line 204: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132807): https://review.coreboot.org/c/coreboot/+/58343/comment/3c30a0ba_ffd6336d PS17, Line 204: } please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132807): https://review.coreboot.org/c/coreboot/+/58343/comment/a3fb9f05_8da46eb5 PS17, Line 213: } code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132807): https://review.coreboot.org/c/coreboot/+/58343/comment/3d2e263c_a8d6e751 PS17, Line 213: } please, no spaces at the start of a line