Attention is currently required from: Raul Rangel, Martin Roth, Bhanu Prakash Maiya, Eric Peers, Rob Barnes, Matt Papageorge, Karthik Ramasubramanian.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58417 )
Change subject: mb/google/guybrush/var/nipperkin: override dxio to turn off WLAN ASPM L1.2/L1.2
......................................................................
Patch Set 8:
(3 comments)
File src/mainboard/google/guybrush/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/58417/comment/6faa1fdc_fa6c5710
PS7, Line 11: fsp_dxio_descriptor guybrush_czn_dxio_descriptors[] = {
Keep the static and pass in the pointer to variant_czn_dxio_descriptors_update
Done
https://review.coreboot.org/c/coreboot/+/58417/comment/3e401ec5_9a26f471
PS7, Line 124: if (is_dev_enabled(DEV_PTR(gpp_bridge_2)))
: guybrush_czn_dxio_descriptors[WWAN_NVME].engine_type = PCIE_ENGINE;
I would prefer to leave this where it was and just have an empty weak method.
Done
File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/58417/comment/330c727c_8feb2c56
PS7, Line 52: variant_czn_dxio_descriptors_update
how about variant_update_dxio_descriptors?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58417
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic7be523626b0ff6e4b1c66ba6af13b15061ef4cb
Gerrit-Change-Number: 58417
Gerrit-PatchSet: 8
Gerrit-Owner: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Sun, 24 Oct 2021 13:01:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment