Attention is currently required from: Poornima Tom, Tim Wawrzynczak, Paul Menzel, Rizwan Qureshi, Sumeet R Pawnikar, Eric Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63949 )
Change subject: ec/google: Add support for ARTG method
......................................................................
Patch Set 6:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/63949/comment/d3ff34e7_412d52d8
PS5, Line 15: https://chromium-review.googlesource.com/c/
: chromiumos/platform/ec/+/3545780
`https://crrev.com/c/3545780%60 […]
Done
File src/ec/google/chromeec/acpi/emem.asl:
https://review.coreboot.org/c/coreboot/+/63949/comment/935b00ac_a2ed46b4
PS2, Line 52: ARTG, 16, // Adapter Rating
At present, we are testing DTT features on brya using legacy EC cahnges, as brya doesn't still suppo […]
Done
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/63949/comment/2e522400_54666aae
PS5, Line 155: /* Local0 *= 0x32 */
why does it need to be multiplied by 50?
Done
https://review.coreboot.org/c/coreboot/+/63949/comment/582430d7_7e07fece
PS5, Line 165: acpigen_pop_len
`acpigen_write_method_end()`
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I501ce59fd9e7f39d8b68f7e757b953ec7fb7f072
Gerrit-Change-Number: 63949
Gerrit-PatchSet: 6
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Comment-Date: Wed, 01 Jun 2022 16:52:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Poornima Tom
poornima.tom@intel.com
Comment-In-Reply-To: Varshit B Pandya
varshit.b.pandya@intel.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-MessageType: comment