Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee. Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54076 )
Change subject: mb/google/volteer/var/volteer2: Configure TCSS OC pins ......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54076/comment/bd70f282_70354e16 PS3, Line 9: volteer
Baseboard sets GPP_E9/USB_OC0# to NF1. […]
From what I've fopund, I think we're ok with setting this in baseboard.
I'm thinking I should move the setting of GPIO_A16 (USB_OC3#) back into baseboard's gpio.c given all variants set it (and the mated USB_OC0# is currently being set in baseboard's gpio.c) If I'm going to make this change in baseboard's devicetree instead of in each variant's override devicetree, I think moving the setting of GPIO_A16 back into baseboard's gpio.c (and out of each variant's GPIO override table) would be safer and makes sense. Thoughts?
-
Nick Vaccaro (Code Review)