Werner Zeh has posted comments on this change. ( https://review.coreboot.org/28730 )
Change subject: siemens/mc_apl1: Make the DDR memory swizzle data configurable ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/28730/1/src/mainboard/siemens/mc_apl1/romsta... File src/mainboard/siemens/mc_apl1/romstage.c:
https://review.coreboot.org/#/c/28730/1/src/mainboard/siemens/mc_apl1/romsta... PS1, Line 80: sz You could just have used (size_t)DQ_BITS_PER_DQS here directly as you have to break the line anyway and now have space. It would increase readability IMO and you can get rid of the variable sz. But it is up to you.