Attention is currently required from: Ravi kumar, Shelley Chen, Martin Roth, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 36:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/da2311ef_b6690a88 PS36, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/a4e5a9bc_327f2375 PS36, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/1c354b9a_3954f0a6 PS36, Line 16: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/938cb9a0_0e147202 PS36, Line 16: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/1d1d416e_75fbb065 PS36, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/5f11e3d1_da8ada12 PS36, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/9567d82d_82a6d29a PS36, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/575027ba_743a4fb1 PS36, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/d6b7e403_93879258 PS36, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/3bfaf0d2_b776ac9f PS36, Line 22: val |= 0x1; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/745629a8_ae5835c4 PS36, Line 22: val |= 0x1; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/a3ca8c6a_c7b740da PS36, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/89f85bce_bf3316e6 PS36, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/dd879b5e_335dfd65 PS36, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/f551eab4_46686c2f PS36, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/8ad885a6_c3b9affc PS36, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/3f79a1a8_0e6f6014 PS36, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/39630e59_cbf2dbea PS36, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/1b3f4267_454cefbd PS36, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/b6f91d1f_d9a29cba PS36, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/adf70cfc_8e29a326 PS36, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/ec7f23f1_61209f0d PS36, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/01fc483e_4d21ce76 PS36, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/65045b9c_8c310a16 PS36, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/3adec6e2_139209ce PS36, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/6ab4f102_734d89c7 PS36, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/be7236c8_1de381c1 PS36, Line 38: cpucp_prepare(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/4b075fe2_2b3bf777 PS36, Line 38: cpucp_prepare(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/6258efe7_60aa2276 PS36, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/e19c4466_8079f9a5 PS36, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/3d6924b2_722915ef PS36, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/3ac1472c_158942b2 PS36, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/0c74f6df_6f737607 PS36, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/3f9a790a_24bfe8d7 PS36, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/e2ae9215_99931b69 PS36, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/6a56a4cc_43989417 PS36, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/be0aade4_39c67564 PS36, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/d18b85aa_e4305105 PS36, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/960014dc_39b98f07 PS36, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/12e291df_1e6fdb56 PS36, Line 47: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/b764492c_a1b56741 PS36, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119423): https://review.coreboot.org/c/coreboot/+/49768/comment/1f36dfcb_7e21db47 PS36, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)