Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
soc/intel/skylake: Align platform.asl with CNL
Refer _WAK and _PTS ASL functions from common platform.asl
TEST=Dump and disassemble DSDT, verify all methods present inside common platform.asl like _WAK, _PTS etc. are still there.
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I625e42b3c49abbb3595a4307da5fc24850a98fbb --- M src/soc/intel/skylake/acpi/platform.asl 1 file changed, 2 insertions(+), 28 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/45980/1
diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl index 6b9dc40..7345864 100644 --- a/src/soc/intel/skylake/acpi/platform.asl +++ b/src/soc/intel/skylake/acpi/platform.asl @@ -2,9 +2,8 @@
/* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl> - -External (_SB.MPTS, MethodObj) -External (_SB.MWAK, MethodObj) +/* Generic indicator for sleep state */ +#include <soc/intel/common/acpi/platform.asl>
/* * The _PIC method is called by the OS to choose between interrupt @@ -19,28 +18,3 @@ /* Remember the OS' IRQ routing choice. */ Store (Arg0, PICM) } - -/* - * The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method (_PTS, 1) -{ - If (CondRefOf (_SB.MPTS)) - { - _SB.MPTS (Arg0) - } -} - -/* The _WAK method is called on system wakeup */ - -Method (_WAK, 1) -{ - If (CondRefOf (_SB.MWAK)) - { - _SB.MWAK (Arg0) - } - - Return (Package (){ 0, 0 }) -}
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
Patch Set 1: Code-Review-1
This is to allow mainboards to provide their own implementation of _PTS and _WAK. CB:35523 would need it.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45980/1/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/45980/1/src/soc/intel/skylake/acpi/... PS1, Line 19: Store a single old syntax :)
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
Patch Set 1: Code-Review+2
Nvm I saw that the common code also provides this.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
Patch Set 1:
Patch Set 1: Code-Review-1
This is to allow mainboards to provide their own implementation of _PTS and _WAK. CB:35523 would need it.
Angel, i didn't understand, mainboard still can keep its own implementation of _PTS/_WAK.
Please take a look src/mainboard/google/dedede/acpi/mainboard.asl(18) :Method (MPTS, 1, Serialized)
it just that SKL code not using common platform.asl code as other SoC is doing
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45980/1/src/soc/intel/skylake/acpi/... File src/soc/intel/skylake/acpi/platform.asl:
https://review.coreboot.org/c/coreboot/+/45980/1/src/soc/intel/skylake/acpi/... PS1, Line 19: Store
a single old syntax :)
yes, cleaning here https://review.coreboot.org/c/coreboot/+/45981/1 😊
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-1
This is to allow mainboards to provide their own implementation of _PTS and _WAK. CB:35523 would need it.
Angel, i didn't understand, mainboard still can keep its own implementation of _PTS/_WAK.
Please take a look src/mainboard/google/dedede/acpi/mainboard.asl(18) :Method (MPTS, 1, Serialized)
it just that SKL code not using common platform.asl code as other SoC is doing
I just didn't realize that common code already had these methods. Sorry for the noise
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45980 )
Change subject: soc/intel/skylake: Align platform.asl with CNL ......................................................................
soc/intel/skylake: Align platform.asl with CNL
Refer _WAK and _PTS ASL functions from common platform.asl
TEST=Dump and disassemble DSDT, verify all methods present inside common platform.asl like _WAK, _PTS etc. are still there.
Signed-off-by: Subrata Banik subrata.banik@intel.com Change-Id: I625e42b3c49abbb3595a4307da5fc24850a98fbb Reviewed-on: https://review.coreboot.org/c/coreboot/+/45980 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/skylake/acpi/platform.asl 1 file changed, 2 insertions(+), 28 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/skylake/acpi/platform.asl b/src/soc/intel/skylake/acpi/platform.asl index 6b9dc40..7345864 100644 --- a/src/soc/intel/skylake/acpi/platform.asl +++ b/src/soc/intel/skylake/acpi/platform.asl @@ -2,9 +2,8 @@
/* Enable ACPI _SWS methods */ #include <soc/intel/common/acpi/acpi_wake_source.asl> - -External (_SB.MPTS, MethodObj) -External (_SB.MWAK, MethodObj) +/* Generic indicator for sleep state */ +#include <soc/intel/common/acpi/platform.asl>
/* * The _PIC method is called by the OS to choose between interrupt @@ -19,28 +18,3 @@ /* Remember the OS' IRQ routing choice. */ Store (Arg0, PICM) } - -/* - * The _PTS method (Prepare To Sleep) is called before the OS is - * entering a sleep state. The sleep state number is passed in Arg0 - */ - -Method (_PTS, 1) -{ - If (CondRefOf (_SB.MPTS)) - { - _SB.MPTS (Arg0) - } -} - -/* The _WAK method is called on system wakeup */ - -Method (_WAK, 1) -{ - If (CondRefOf (_SB.MWAK)) - { - _SB.MWAK (Arg0) - } - - Return (Package (){ 0, 0 }) -}
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Subrata Banik (Code Review)