John E. Kabat Jr. has uploaded this change for review. ( https://review.coreboot.org/21769
Change subject: drivers/elog: Fix to allow debug to work ......................................................................
drivers/elog: Fix to allow debug to work
add to Makefile.inc required file hexdump.c if CONFIG_ELOG_DEBUG is set correct debug message in elog.c to use correct sizes
Change-Id: I3d5547eed8ada7c4bdcbbb8bb9d6965ade73beda Signed-off-by: John E. Kabat Jr john.kabat@scarletltd.com --- M src/drivers/elog/Makefile.inc M src/drivers/elog/elog.c 2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/21769/1
diff --git a/src/drivers/elog/Makefile.inc b/src/drivers/elog/Makefile.inc index 79a7cc0..dbe3b39 100644 --- a/src/drivers/elog/Makefile.inc +++ b/src/drivers/elog/Makefile.inc @@ -1,6 +1,7 @@ ramstage-$(CONFIG_ELOG) += elog.c
smm-$(CONFIG_ELOG_GSMI) += elog.c gsmi.c +smm-$(CONFIG_ELOG_DEBUG) += hexdump.c
romstage-$(CONFIG_ELOG_BOOT_COUNT) += boot_count.c ramstage-$(CONFIG_ELOG_BOOT_COUNT) += boot_count.c diff --git a/src/drivers/elog/elog.c b/src/drivers/elog/elog.c index 1c17561..c8f221a 100644 --- a/src/drivers/elog/elog.c +++ b/src/drivers/elog/elog.c @@ -324,8 +324,8 @@
address = rdev_mmap(rdev, offset, size);
- elog_debug("%s(address=0x%p offset=0x%08x size=%u)\n", __func__, - address, offset, size); + elog_debug("%s(address=0x%p offset=0x%08zx size=%zu)\n", __func__, + address, offset, size);
if (address == NULL) return;