Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44644 )
Change subject: mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration ......................................................................
mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration
ASUS A88XM-E doesn't have a TPM header, so couldn't have a TPM and it makes sense to disable a related SeaBIOS option for this board. This reduces the size of compiled SeaBIOS by 132736-120832=11904 bytes.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Ieff8cb24ddb23483b992db5e311030ce0316867d --- M src/mainboard/asus/a88xm-e/Kconfig A src/mainboard/asus/a88xm-e/config_seabios 2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/44/44644/1
diff --git a/src/mainboard/asus/a88xm-e/Kconfig b/src/mainboard/asus/a88xm-e/Kconfig index 6874e9e..139f989 100644 --- a/src/mainboard/asus/a88xm-e/Kconfig +++ b/src/mainboard/asus/a88xm-e/Kconfig @@ -56,4 +56,8 @@ bool default n
+config PAYLOAD_CONFIGFILE + string + default "$(top)/src/mainboard/$(MAINBOARDDIR)/config_seabios" if PAYLOAD_SEABIOS + endif # BOARD_ASUS_A88XM_E diff --git a/src/mainboard/asus/a88xm-e/config_seabios b/src/mainboard/asus/a88xm-e/config_seabios new file mode 100644 index 0000000..26188f7 --- /dev/null +++ b/src/mainboard/asus/a88xm-e/config_seabios @@ -0,0 +1,5 @@ +### +### SeaBIOS custom configuration for ASUS A88XM-E +### +# CONFIG_TCGBIOS is not set +#
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44644 )
Change subject: mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration ......................................................................
Patch Set 1:
Please take a look on this one - like CB:33870 but only disabling TPM now.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44644 )
Change subject: mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44644/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44644/1//COMMIT_MSG@9 PS1, Line 9: ASUS A88XM-E doesn't have a TPM header Um, and what's that thing just above the PCIe x16 slot?
https://www.asus.com/media/global/products/3bTUqYQmBfvTS2pf/Rd2B6UOtz1rcvfdL...
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44644 )
Change subject: mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44644/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44644/1//COMMIT_MSG@9 PS1, Line 9: ASUS A88XM-E doesn't have a TPM header
Um, and what's that thing just above the PCIe x16 slot? […]
Indeed, you are right. What AM1I-A has and A88XM-E hasn't, is LPT header. TPM header is indeed there on both boards, so - abandoning this now.
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44644 )
Change subject: mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration ......................................................................
Abandoned
ASUS A88XM-E has a TPM header, so abandoning. Although, without an open hardware TPM this module can't be "trusted" by a security-conscious...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44644 )
Change subject: mb/asus/a88xm-e: Disable TPM at SeaBIOS confuration ......................................................................
Patch Set 1:
I have a better (easier to approve) idea: Disable TPM support in SeaBIOS if coreboot isn't built with TPM support.
-
Angel Pons (Code Review) -
Mike Banon (Code Review)