Attention is currently required from: Hung-Te Lin, Paul Menzel, Yidi Lin.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79776?usp=email )
Change subject: soc/mediatek: Add common implementation to configure display
......................................................................
Patch Set 3:
(1 comment)
File src/soc/mediatek/mt8188/include/soc/ddp.h:
https://review.coreboot.org/c/coreboot/+/79776/comment/2b23634d_255a4efd :
PS3, Line 286: void mtk_ddp_init(void);
: void mtk_ddp_mode_set(const struct edid *edid, enum disp_path_sel path);
Since these 2 functions are called from common/display.c, the declarations should also be moved to a common header.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79776?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I403bba8a826de5f3fb2ea96a5403725ff194164f
Gerrit-Change-Number: 79776
Gerrit-PatchSet: 3
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 09 Jan 2024 07:14:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment