HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36063 )
Change subject: src: Remove unused include '<device/pci_ids.h>' ......................................................................
src: Remove unused include '<device/pci_ids.h>'
Change-Id: Ic90dcff9d0b49a75a26556e4a1884a2954ef68f6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/cardbus_device.c M src/device/pci_class.c M src/device/pciexp_device.c M src/drivers/emulation/qemu/bochs.c M src/drivers/emulation/qemu/cirrus.c M src/drivers/net/ne2k.c M src/drivers/uart/oxpcie.c M src/soc/amd/picasso/sata.c M src/soc/amd/picasso/southbridge.c M src/soc/amd/stoneyridge/sata.c M src/soc/amd/stoneyridge/southbridge.c M src/southbridge/amd/cimx/sb800/early.c M src/southbridge/amd/cimx/sb900/early.c M src/southbridge/amd/pi/hudson/bootblock.c M src/southbridge/intel/i82371eb/fadt.c 15 files changed, 0 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/36063/1
diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index 48c54bc..f7decb3 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -15,7 +15,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/pci_ids.h> #include <device/cardbus.h>
/* diff --git a/src/device/pci_class.c b/src/device/pci_class.c index ca36154..0aa2f28 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -14,7 +14,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/pci_ids.h> #include <stdlib.h>
typedef struct { diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index 9a45be8..71702a7 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -15,7 +15,6 @@ #include <delay.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/pciexp.h>
diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c index 22095ef..e4762e9 100644 --- a/src/drivers/emulation/qemu/bochs.c +++ b/src/drivers/emulation/qemu/bochs.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <pc80/vga.h> #include <pc80/vga_io.h> diff --git a/src/drivers/emulation/qemu/cirrus.c b/src/drivers/emulation/qemu/cirrus.c index ed5a4f4..688fcba 100644 --- a/src/drivers/emulation/qemu/cirrus.c +++ b/src/drivers/emulation/qemu/cirrus.c @@ -21,7 +21,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <pc80/vga.h> #include <pc80/vga_io.h> diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index c7b53e4..35d45ea 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -31,7 +31,6 @@ #include <console/ne2k.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <stdlib.h> #include <ip_checksum.h> diff --git a/src/drivers/uart/oxpcie.c b/src/drivers/uart/oxpcie.c index 2f40c3f..72ac68b 100644 --- a/src/drivers/uart/oxpcie.c +++ b/src/drivers/uart/oxpcie.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <console/console.h> #include <console/uart.h> #include <device/mmio.h> diff --git a/src/soc/amd/picasso/sata.c b/src/soc/amd/picasso/sata.c index 6740698..d67f5b4 100644 --- a/src/soc/amd/picasso/sata.c +++ b/src/soc/amd/picasso/sata.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <amdblocks/sata.h> diff --git a/src/soc/amd/picasso/southbridge.c b/src/soc/amd/picasso/southbridge.c index e6fc0de..00e7b0f 100644 --- a/src/soc/amd/picasso/southbridge.c +++ b/src/soc/amd/picasso/southbridge.c @@ -19,7 +19,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <cbmem.h> #include <amdblocks/amd_pci_util.h> diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c index 6740698..d67f5b4 100644 --- a/src/soc/amd/stoneyridge/sata.c +++ b/src/soc/amd/stoneyridge/sata.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <amdblocks/sata.h> diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 45408ea..d7a09aa 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -19,7 +19,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <cbmem.h> #include <amdblocks/amd_pci_util.h> diff --git a/src/southbridge/amd/cimx/sb800/early.c b/src/southbridge/amd/cimx/sb800/early.c index 7d93c81..4882957 100644 --- a/src/southbridge/amd/cimx/sb800/early.c +++ b/src/southbridge/amd/cimx/sb800/early.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_ids.h> #include "SBPLATFORM.h" #include "sb_cimx.h" #include "cfg.h" /*sb800_cimx_config*/ diff --git a/src/southbridge/amd/cimx/sb900/early.c b/src/southbridge/amd/cimx/sb900/early.c index 1aa9a5a..ccada12 100644 --- a/src/southbridge/amd/cimx/sb900/early.c +++ b/src/southbridge/amd/cimx/sb900/early.c @@ -17,7 +17,6 @@ #define __SIMPLE_DEVICE__
#include <stdint.h> -#include <device/pci_ids.h> #include <arch/io.h> #include "SbPlatform.h" #include "sb_cimx.h" diff --git a/src/southbridge/amd/pi/hudson/bootblock.c b/src/southbridge/amd/pi/hudson/bootblock.c index bdda5ed..f12cec8 100644 --- a/src/southbridge/amd/pi/hudson/bootblock.c +++ b/src/southbridge/amd/pi/hudson/bootblock.c @@ -15,7 +15,6 @@
#include <stdint.h> #include <device/pci_ops.h> -#include <device/pci_ids.h>
/* * Enable 4MB (LPC) ROM access at 0xFFC00000 - 0xFFFFFFFF. diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c index 9e43e62..cbfb0af 100644 --- a/src/southbridge/intel/i82371eb/fadt.c +++ b/src/southbridge/intel/i82371eb/fadt.c @@ -21,7 +21,6 @@ #include <arch/acpi.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <version.h>
#include "i82371eb.h"
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36063 )
Change subject: src: Remove unused include '<device/pci_ids.h>' ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36063 )
Change subject: src: Remove unused include '<device/pci_ids.h>' ......................................................................
src: Remove unused include '<device/pci_ids.h>'
Change-Id: Ic90dcff9d0b49a75a26556e4a1884a2954ef68f6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/36063 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/device/cardbus_device.c M src/device/pci_class.c M src/device/pciexp_device.c M src/drivers/emulation/qemu/bochs.c M src/drivers/emulation/qemu/cirrus.c M src/drivers/net/ne2k.c M src/drivers/uart/oxpcie.c M src/soc/amd/picasso/sata.c M src/soc/amd/picasso/southbridge.c M src/soc/amd/stoneyridge/sata.c M src/soc/amd/stoneyridge/southbridge.c M src/southbridge/amd/cimx/sb800/early.c M src/southbridge/amd/cimx/sb900/early.c M src/southbridge/amd/pi/hudson/bootblock.c M src/southbridge/intel/i82371eb/fadt.c 15 files changed, 0 insertions(+), 15 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/device/cardbus_device.c b/src/device/cardbus_device.c index 48c54bc..f7decb3 100644 --- a/src/device/cardbus_device.c +++ b/src/device/cardbus_device.c @@ -15,7 +15,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/pci_ids.h> #include <device/cardbus.h>
/* diff --git a/src/device/pci_class.c b/src/device/pci_class.c index ca36154..0aa2f28 100644 --- a/src/device/pci_class.c +++ b/src/device/pci_class.c @@ -14,7 +14,6 @@ #include <device/device.h> #include <device/pci.h> #include <device/pci_ops.h> -#include <device/pci_ids.h> #include <stdlib.h>
typedef struct { diff --git a/src/device/pciexp_device.c b/src/device/pciexp_device.c index 9a45be8..71702a7 100644 --- a/src/device/pciexp_device.c +++ b/src/device/pciexp_device.c @@ -15,7 +15,6 @@ #include <delay.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/pciexp.h>
diff --git a/src/drivers/emulation/qemu/bochs.c b/src/drivers/emulation/qemu/bochs.c index 22095ef..e4762e9 100644 --- a/src/drivers/emulation/qemu/bochs.c +++ b/src/drivers/emulation/qemu/bochs.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <pc80/vga.h> #include <pc80/vga_io.h> diff --git a/src/drivers/emulation/qemu/cirrus.c b/src/drivers/emulation/qemu/cirrus.c index ed5a4f4..688fcba 100644 --- a/src/drivers/emulation/qemu/cirrus.c +++ b/src/drivers/emulation/qemu/cirrus.c @@ -21,7 +21,6 @@ #include <console/console.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <pc80/vga.h> #include <pc80/vga_io.h> diff --git a/src/drivers/net/ne2k.c b/src/drivers/net/ne2k.c index c7b53e4..35d45ea 100644 --- a/src/drivers/net/ne2k.c +++ b/src/drivers/net/ne2k.c @@ -31,7 +31,6 @@ #include <console/ne2k.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <stdlib.h> #include <ip_checksum.h> diff --git a/src/drivers/uart/oxpcie.c b/src/drivers/uart/oxpcie.c index 2f40c3f..72ac68b 100644 --- a/src/drivers/uart/oxpcie.c +++ b/src/drivers/uart/oxpcie.c @@ -16,7 +16,6 @@ #include <device/device.h> #include <device/pci_def.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <console/console.h> #include <console/uart.h> #include <device/mmio.h> diff --git a/src/soc/amd/picasso/sata.c b/src/soc/amd/picasso/sata.c index 6740698..d67f5b4 100644 --- a/src/soc/amd/picasso/sata.c +++ b/src/soc/amd/picasso/sata.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <amdblocks/sata.h> diff --git a/src/soc/amd/picasso/southbridge.c b/src/soc/amd/picasso/southbridge.c index e6fc0de..00e7b0f 100644 --- a/src/soc/amd/picasso/southbridge.c +++ b/src/soc/amd/picasso/southbridge.c @@ -19,7 +19,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <cbmem.h> #include <amdblocks/amd_pci_util.h> diff --git a/src/soc/amd/stoneyridge/sata.c b/src/soc/amd/stoneyridge/sata.c index 6740698..d67f5b4 100644 --- a/src/soc/amd/stoneyridge/sata.c +++ b/src/soc/amd/stoneyridge/sata.c @@ -15,7 +15,6 @@
#include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <device/pci_def.h> #include <amdblocks/sata.h> diff --git a/src/soc/amd/stoneyridge/southbridge.c b/src/soc/amd/stoneyridge/southbridge.c index 45408ea..d7a09aa 100644 --- a/src/soc/amd/stoneyridge/southbridge.c +++ b/src/soc/amd/stoneyridge/southbridge.c @@ -19,7 +19,6 @@ #include <cpu/x86/smm.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <device/pci_ops.h> #include <cbmem.h> #include <amdblocks/amd_pci_util.h> diff --git a/src/southbridge/amd/cimx/sb800/early.c b/src/southbridge/amd/cimx/sb800/early.c index 7d93c81..4882957 100644 --- a/src/southbridge/amd/cimx/sb800/early.c +++ b/src/southbridge/amd/cimx/sb800/early.c @@ -14,7 +14,6 @@ */
#include <stdint.h> -#include <device/pci_ids.h> #include "SBPLATFORM.h" #include "sb_cimx.h" #include "cfg.h" /*sb800_cimx_config*/ diff --git a/src/southbridge/amd/cimx/sb900/early.c b/src/southbridge/amd/cimx/sb900/early.c index 1aa9a5a..ccada12 100644 --- a/src/southbridge/amd/cimx/sb900/early.c +++ b/src/southbridge/amd/cimx/sb900/early.c @@ -17,7 +17,6 @@ #define __SIMPLE_DEVICE__
#include <stdint.h> -#include <device/pci_ids.h> #include <arch/io.h> #include "SbPlatform.h" #include "sb_cimx.h" diff --git a/src/southbridge/amd/pi/hudson/bootblock.c b/src/southbridge/amd/pi/hudson/bootblock.c index bdda5ed..f12cec8 100644 --- a/src/southbridge/amd/pi/hudson/bootblock.c +++ b/src/southbridge/amd/pi/hudson/bootblock.c @@ -15,7 +15,6 @@
#include <stdint.h> #include <device/pci_ops.h> -#include <device/pci_ids.h>
/* * Enable 4MB (LPC) ROM access at 0xFFC00000 - 0xFFFFFFFF. diff --git a/src/southbridge/intel/i82371eb/fadt.c b/src/southbridge/intel/i82371eb/fadt.c index 9e43e62..cbfb0af 100644 --- a/src/southbridge/intel/i82371eb/fadt.c +++ b/src/southbridge/intel/i82371eb/fadt.c @@ -21,7 +21,6 @@ #include <arch/acpi.h> #include <device/device.h> #include <device/pci.h> -#include <device/pci_ids.h> #include <version.h>
#include "i82371eb.h"
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)