Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40235 )
Change subject: soc/intel/common/systemagent: Change PCIEX_LENGTH to PCIEX_LENGTH_MIB
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40235/1/src/soc/intel/common/block/...
File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/40235/1/src/soc/intel/common/block/...
PS1, Line 46: /* TODO- include condition check for New SoC implememtation */
Planning to include condition like #if (CONFIG_SA_PCIEXBAR_LENGTH_BIT_WIDTH == 3). […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40235
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I236be960c68727aceca760a5e42cade12a3adb99
Gerrit-Change-Number: 40235
Gerrit-PatchSet: 5
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 14 Apr 2020 18:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Usha P
usha.p@intel.com
Gerrit-MessageType: comment