Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/19055 )
Change subject: soc/intel/skylake: Clean up code by using common FAST_SPI module
......................................................................
Patch Set 22:
(1 comment)
https://review.coreboot.org/#/c/19055/22/src/soc/intel/skylake/pch.c
File src/soc/intel/skylake/pch.c:
PS22, Line 24: #include <intelblocks/fast_spi.h>
why is this required here?
--
To view, visit
https://review.coreboot.org/19055
To unsubscribe, visit
https://review.coreboot.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fc90504d322db70ed4ea644b1593cc0605b5fe8
Gerrit-PatchSet: 22
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Owner: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Barnali Sarkar
barnali.sarkar@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Hannah Williams
hannah.williams@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Shaunak Saha
shaunak.saha@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
Gerrit-HasComments: Yes