Change in coreboot[master]: drivers/i2c/cs42l42: Add driver for generating device in SSDT
Attention is currently required from: Furquan Shaikh, Martin Roth, Paul Menzel, Zhuohao Lee, Karthik Ramasubramanian, EricR Lai. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52395 )
Change subject: drivers/i2c/cs42l42: Add driver for generating device in SSDT ......................................................................
Patch Set 6:
(20 comments)
File src/drivers/i2c/cs42l42/chip.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/a78815d3_c7b7c644 PS6, Line 6: RISE_DEB_0_MS = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/e5c360d8_10b2955c PS6, Line 7: RISE_DEB_125_MS = 1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/30138c54_b49a6c6f PS6, Line 8: RISE_DEB_250_MS = 2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/cd600c82_a76b2e0d PS6, Line 9: RISE_DEB_500_MS = 3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/20344900_a5f448e7 PS6, Line 10: RISE_DEB_750_MS = 4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/3fe1085a_49c43772 PS6, Line 11: RISE_DEB_1000_MS = 5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/11c0abee_93ed3cd7 PS6, Line 12: RISE_DEB_1250_MS = 6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/02267c6a_b632cd2d PS6, Line 13: RISE_DEB_1500_MS = 7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/1b8423ba_554dee10 PS6, Line 17: FALL_DEB_0_MS = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/6af69c6d_6a28ad90 PS6, Line 18: FALL_DEB_125_MS = 1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/e6ba8ba8_381689e3 PS6, Line 19: FALL_DEB_250_MS = 2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/4e0f62a2_dfb619df PS6, Line 20: FALL_DEB_500_MS = 3, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/1e17a929_e6d5a620 PS6, Line 21: FALL_DEB_750_MS = 4, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/114a3c85_87495ce3 PS6, Line 22: FALL_DEB_1000_MS = 5, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/8bc639f2_459419fd PS6, Line 23: FALL_DEB_1250_MS = 6, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/67bd29e4_68b96737 PS6, Line 24: FALL_DEB_1500_MS = 7, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/1d888d14_3060c387 PS6, Line 28: HSBIAS_RAMP_FAST_RISE_SLOW_FALL = 0, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/1503ff89_9c1cd153 PS6, Line 29: HSBIAS_RAMP_FAST = 1, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/6caaec93_f8e2c567 PS6, Line 30: HSBIAS_RAMP_SLOW = 2, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-117531): https://review.coreboot.org/c/coreboot/+/52395/comment/76dc15f3_b45099ec PS6, Line 31: HSBIAS_RAMP_SLOWEST = 3, please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)