Change in coreboot[master]: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode
Mike Banon has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38240 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode
Set up the proper IRQ routing for OHCI/EHCI devices which appear if XHCI controller is disabled (CONFIG_HUDSON_XHCI_ENABLE is not set). Now both "USB 3.0" ports are working fine at OHCI/EHCI "USB 2.0" mode.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Id9c524352ff386ce79818248cfd7e5b976637d47 --- M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/asus/am1i-a/acpi/routing.asl A src/mainboard/asus/am1i-a/config_seabios M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/am1i-a/irq_tables.c M src/mainboard/asus/am1i-a/mainboard.c M src/mainboard/asus/am1i-a/mptable.c 7 files changed, 33 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/38240/1
diff --git a/src/mainboard/asus/am1i-a/Kconfig b/src/mainboard/asus/am1i-a/Kconfig index a0dae9f..172d808 100644 --- a/src/mainboard/asus/am1i-a/Kconfig +++ b/src/mainboard/asus/am1i-a/Kconfig @@ -37,7 +37,7 @@
config IRQ_SLOT_COUNT int - default 9 + default 10
config ONBOARD_VGA_IS_PRIMARY bool diff --git a/src/mainboard/asus/am1i-a/acpi/routing.asl b/src/mainboard/asus/am1i-a/acpi/routing.asl index 95881fa..8b21a25 100644 --- a/src/mainboard/asus/am1i-a/acpi/routing.asl +++ b/src/mainboard/asus/am1i-a/acpi/routing.asl @@ -48,8 +48,14 @@ Package(){0x0013FFFF, 0, INTC, 0 }, Package(){0x0013FFFF, 1, INTB, 0 },
- /* Bus 0, Dev 10 Func 0 - USB: XHCI */ + /* Bus 0, Dev 16 Func 0 - USB: OHCI */ + /* Bus 0, Dev 16 Func 2 - USB: EHCI */ + Package(){0x0016FFFF, 0, INTC, 0 }, + Package(){0x0016FFFF, 1, INTB, 0 }, + + /* Bus 0, Dev 10 - USB: XHCI func 0, 1 */ Package(){0x0010FFFF, 0, INTC, 0 }, + Package(){0x0010FFFF, 1, INTB, 0 },
/* Bus 0, Dev 11 - SATA controller */ Package(){0x0011FFFF, 0, INTD, 0 }, @@ -87,8 +93,14 @@ Package(){0x0013FFFF, 0, 0, 18 }, Package(){0x0013FFFF, 1, 0, 17 },
- /* Bus 0, Dev 10, Func 0 - USB: XHCI */ + /* Bus 0, Dev 16 Func 0 - USB: OHCI */ + /* Bus 0, Dev 16 Func 1 - USB: EHCI */ + Package(){0x0016FFFF, 0, 0, 18 }, + Package(){0x0016FFFF, 1, 0, 17 }, + + /* Bus 0, Dev 10 - USB: XHCI func 0, 1 */ Package(){0x0010FFFF, 0, 0, 18 }, + Package(){0x0010FFFF, 1, 0, 17 },
/* Bus 0, Dev 11 - SATA controller */ Package(){0x0011FFFF, 0, 0, 19 }, diff --git a/src/mainboard/asus/am1i-a/config_seabios b/src/mainboard/asus/am1i-a/config_seabios new file mode 100644 index 0000000..0ee9cea --- /dev/null +++ b/src/mainboard/asus/am1i-a/config_seabios @@ -0,0 +1,6 @@ +### +### SeaBIOS custom configuration for ASUS AM1I-A +### +# CONFIG_MEGASAS is not set +# CONFIG_NVME is not set +# diff --git a/src/mainboard/asus/am1i-a/devicetree.cb b/src/mainboard/asus/am1i-a/devicetree.cb index 8e44874..2d7265a 100644 --- a/src/mainboard/asus/am1i-a/devicetree.cb +++ b/src/mainboard/asus/am1i-a/devicetree.cb @@ -84,6 +84,8 @@ end end #device pci 14.3 # LPC device pci 14.7 off end # SD - no card reader present + device pci 16.0 on end # OHCI USB + device pci 16.2 on end # EHCI USB end #chip southbridge/amd/agesa/hudson
chip northbridge/amd/agesa/family16kb diff --git a/src/mainboard/asus/am1i-a/irq_tables.c b/src/mainboard/asus/am1i-a/irq_tables.c index c8ccbeb..d29fc15 100644 --- a/src/mainboard/asus/am1i-a/irq_tables.c +++ b/src/mainboard/asus/am1i-a/irq_tables.c @@ -26,7 +26,7 @@ 0x439d, /* Device */ 0, /* Miniport */ { 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 }, /* u8 rfu[11] */ - 0xa8, /* Checksum (has to be set to some value that + 0x3b, /* Checksum (has to be set to some value that * would give 0 after the sum of all bytes * for this structure (including checksum). */ @@ -39,6 +39,7 @@ {0x00, (0x12 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, {0x00, (0x13 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, {0x00, (0x14 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, + {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, {0x01, (0x00 << 3) | 0x0, {{0x01, 0x9cb8}, {0x02, 0x9cb8}, {0x03, 0x9cb8}, {0x04, 0x9cb8}}, 0x0, 0x0}, {0x02, (0x00 << 3) | 0x0, {{0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, } diff --git a/src/mainboard/asus/am1i-a/mainboard.c b/src/mainboard/asus/am1i-a/mainboard.c index bd6d3a3..fa01472 100644 --- a/src/mainboard/asus/am1i-a/mainboard.c +++ b/src/mainboard/asus/am1i-a/mainboard.c @@ -34,8 +34,8 @@ [0x10] = 0x1F,0x1F,0x1F,0x03,0x1F,0x1F,0x1F,0x1F, /* IMC INT0 - 5 */ [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, - /* USB Devs 18/19 INTA-B */ - [0x30] = 0x05,0x04,0x05,0x04,0x1F,0x1F, + /* USB Devs 18/19/22 INTA-B */ + [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, /* RSVD, SATA */ [0x40] = 0x1F, 0x07 }; @@ -49,8 +49,8 @@ [0x10] = 0x09,0x1F,0x1F,0x10,0x1F,0x1F,0x1F,0x1F, /* IMC INT0 - 5 */ [0x20] = 0x1F,0x1F,0x1F,0x1F,0x1F,0x1F, - /* USB Devs 18/19 INTA-B */ - [0x30] = 0x12,0x11,0x12,0x11,0x1F,0x1F, + /* USB Devs 18/19/22 INTA-B */ + [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, /* RSVD, SATA */ [0x40] = 0x1F, 0x13 }; @@ -77,6 +77,8 @@ {EHCI1_DEVFN, {PIRQ_NC, PIRQ_EHCI1, PIRQ_NC, PIRQ_NC}}, /* EHCI1: 12.2 */ {OHCI2_DEVFN, {PIRQ_OHCI2, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI2: 13.0 */ {EHCI2_DEVFN, {PIRQ_NC, PIRQ_EHCI2, PIRQ_NC, PIRQ_NC}}, /* EHCI2: 13.2 */ + {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ + {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ {HDA_DEVFN, {PIRQ_HDA, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* HDA: 14.2 */ };
diff --git a/src/mainboard/asus/am1i-a/mptable.c b/src/mainboard/asus/am1i-a/mptable.c index 9efcab3..218d85f 100644 --- a/src/mainboard/asus/am1i-a/mptable.c +++ b/src/mainboard/asus/am1i-a/mptable.c @@ -91,6 +91,8 @@ PCI_INT(0x0, 0x12, 0x1, intr_data_ptr[PIRQ_EHCI1]); PCI_INT(0x0, 0x13, 0x0, intr_data_ptr[PIRQ_OHCI2]); PCI_INT(0x0, 0x13, 0x1, intr_data_ptr[PIRQ_EHCI2]); + PCI_INT(0x0, 0x16, 0x0, intr_data_ptr[PIRQ_OHCI3]); + PCI_INT(0x0, 0x16, 0x1, intr_data_ptr[PIRQ_EHCI3]);
/* Southbridge HD Audio */ PCI_INT(0x0, 0x14, 0x0, intr_data_ptr[PIRQ_HDA]);
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38240 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
Patch Set 1:
(28 comments)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... File src/mainboard/asus/am1i-a/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/i... PS1, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... File src/mainboard/asus/am1i-a/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... File src/mainboard/asus/am1i-a/mptable.c:
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 94: PCI_INT(0x0, 0x16, 0x0, intr_data_ptr[PIRQ_OHCI3]); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 94: PCI_INT(0x0, 0x16, 0x0, intr_data_ptr[PIRQ_OHCI3]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 95: PCI_INT(0x0, 0x16, 0x1, intr_data_ptr[PIRQ_EHCI3]); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/38240/1/src/mainboard/asus/am1i-a/m... PS1, Line 95: PCI_INT(0x0, 0x16, 0x1, intr_data_ptr[PIRQ_EHCI3]); please, no spaces at the start of a line
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38240
to look at the new patch set (#2).
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode
Set up the proper IRQ routing for OHCI/EHCI devices which appear if XHCI controller is disabled (CONFIG_HUDSON_XHCI_ENABLE is not set). Now both "USB 3.0" ports are working fine at OHCI/EHCI "USB 2.0" mode.
Signed-off-by: Mike Banon mikebdp2@gmail.com Change-Id: Id9c524352ff386ce79818248cfd7e5b976637d47 --- M src/mainboard/asus/am1i-a/Kconfig M src/mainboard/asus/am1i-a/acpi/routing.asl A src/mainboard/asus/am1i-a/config_seabios M src/mainboard/asus/am1i-a/devicetree.cb M src/mainboard/asus/am1i-a/irq_tables.c M src/mainboard/asus/am1i-a/mainboard.c M src/mainboard/asus/am1i-a/mptable.c 7 files changed, 33 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/38240/2
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38240 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
Patch Set 2:
(18 comments)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/i... File src/mainboard/asus/am1i-a/irq_tables.c:
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/i... PS2, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, line over 96 characters
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/i... PS2, Line 42: {0x00, (0x16 << 3) | 0x0, {{0x03, 0x9cb8}, {0x02, 0x9cb8}, {0x00, 0x0000}, {0x00, 0x0000}}, 0x0, 0x0}, space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... File src/mainboard/asus/am1i-a/mainboard.c:
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 38: [0x30] = 0x05,0x04,0x05,0x04,0x05,0x04,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 53: [0x30] = 0x12,0x11,0x12,0x11,0x12,0x11,0x1F,0x1F, space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 80: {OHCI3_DEVFN, {PIRQ_OHCI3, PIRQ_NC, PIRQ_NC, PIRQ_NC}}, /* OHCI3: 16.0 */ space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/m... PS2, Line 81: {EHCI3_DEVFN, {PIRQ_NC, PIRQ_EHCI3, PIRQ_NC, PIRQ_NC}}, /* EHCI3: 16.2 */ space required after that close brace '}'
Mike Banon has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/38240 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
Abandoned
Too many stupid mistakes regarding the tabs.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38240 )
Change subject: asus/am1i-a: fix the blue "USB 3.0" ports for OHCI/EHCI "USB 2.0" mode ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/c... File src/mainboard/asus/am1i-a/config_seabios:
https://review.coreboot.org/c/coreboot/+/38240/2/src/mainboard/asus/am1i-a/c... PS2, Line 4: # CONFIG_MEGASAS is not set Are these changes relevant to the fix?
-
build bot (Jenkins) (Code Review) -
Michał Żygowski (Code Review)
-
Mike Banon (Code Review)