Attention is currently required from: Nico Huber, Maulik V Vaghela, Sugnan Prabhu S, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59124 )
Change subject: soc/intel/common: Add CPU related APIs
......................................................................
Patch Set 2:
(5 comments)
File src/soc/intel/common/block/cpu/cpulib.c:
https://review.coreboot.org/c/coreboot/+/59124/comment/b12d7569_893786d2
PS1, Line 190: int
looking at return statement at line 196 below, shouldn't this be "bool" ?
Done
https://review.coreboot.org/c/coreboot/+/59124/comment/b6f7b076_83b9d6ed
PS1, Line 198: FALSE
in that way, you don't need if and else separately […]
Ack
https://review.coreboot.org/c/coreboot/+/59124/comment/c6320f5d_348d3552
PS1, Line 204: ecx
may be ? […]
Ack
https://review.coreboot.org/c/coreboot/+/59124/comment/63dfe7d4_3576a237
PS1, Line 301: (uint8_t)
you don't need this typecasting. […]
I will do it separate patch.
File src/soc/intel/common/block/include/intelblocks/cpulib.h:
https://review.coreboot.org/c/coreboot/+/59124/comment/6fbac475_0d74f9d1
PS1, Line 144:
Remove unnecessary line
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59124
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I680f43952ab4abce6e342206688ad32814970a91
Gerrit-Change-Number: 59124
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.corp-partner.google.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 16 Nov 2021 20:24:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment