Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Paul Menzel, Tarun, Zhuohao Lee.
Tony Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81564?usp=email )
Change subject: mb/google/rex/var/deku: Swap LAN device indices for correct MAC address
......................................................................
Patch Set 5:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81564/comment/bc01ed17_f3aa0a60 :
PS4, Line 7: Swap LAN device indices
Maybe even: […]
Done
https://review.coreboot.org/c/coreboot/+/81564/comment/b9f95761_60eb3493 :
PS4, Line 9: Deku has 2 ethernet ports, due to the LAN devices indices were swapped.
: So set vpd ethernet_mac0 will affect the eth1 and set vpd ethernet_mac1 will affect the eth0 from ifconfig.
Maybe use: […]
Done
https://review.coreboot.org/c/coreboot/+/81564/comment/d6923809_0ed408fb :
PS4, Line 12: This CL is to correct the device indices for LAN devices so ethernet_mac[0-1] in vpd can apply to the correct ethernet ports.
Please use 72 characters per line.
Done
https://review.coreboot.org/c/coreboot/+/81564/comment/8afcb841_7f6902cd :
PS4, Line 12: This CL is to correct
Correct
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81564?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id1508104cbb5cf0a234f34f9db19cc535fdb634b
Gerrit-Change-Number: 81564
Gerrit-PatchSet: 5
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jakub Czapiga
czapiga@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kevin Chiu
kevin.chiu.17802@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Jakub Czapiga
czapiga@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Tue, 02 Apr 2024 00:34:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment