EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48139/1
diff --git a/src/mainboard/google/brya/variants/baseboard/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/devicetree.cb index fbd7d72..e01c4ff 100644 --- a/src/mainboard/google/brya/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/devicetree.cb @@ -2,4 +2,42 @@ device cpu_cluster 0 on device lapic 0 on end end + + device domain 0 on + device ref igpu on end + device ref dptf on end + device ref tbt_pcie_rp0 on end + device ref tbt_pcie_rp1 on end + device ref tbt_pcie_rp2 on end + device ref tbt_dma0 on end + device ref tbt_dma1 on end + device ref gna on end + device ref north_xhci on end + device ref cnvi_bt on end + device ref south_xhci on end + device ref shared_ram on end + device ref cnvi_wifi on + chip drivers/wifi/generic + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end + end + device ref heci1 on end + device ref sata on end + device ref pcie_rp1 on end #USB3-1 Type A + device ref pcie_rp4 on end #USB3-4 WWAN + device ref pcie_rp5 on end #PCIE5 WLAN + device ref pcie_rp6 on end #PCIE6 WWAN + device ref pcie_rp8 on end #PCIE8 SD card + device ref pcie_rp9 on end #PCIE9-12 SSD + device ref uart0 on end + device ref gspi0 on end + device ref gspi1 on end + device ref pch_espi on + chip ec/google/chromeec + device pnp 0c09.0 on end + end + end + device ref hda on end + end end
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 1:
@Tim, anything else we should remove from baseboard to variant or vice versa?
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48139
to look at the new patch set (#3).
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48139/3
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 4:
@Tim, do we need add cnvi_bt? You didn't add it in chipset.cb.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48139
to look at the new patch set (#5).
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48139/5
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 5:
Patch Set 4:
@Tim, do we need add cnvi_bt? You didn't add it in chipset.cb.
I patched it and correct some 😊
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48139
to look at the new patch set (#6).
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48139/6
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48139
to look at the new patch set (#7).
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 38 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48139/7
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 12: device ref gna on end Let's leave this off for now, we may not need it.
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 26: device ref sata on end Also I'm not aware of using SATA for Brya as of right now
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 12: device ref gna on end
Let's leave this off for now, we may not need it.
okay
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 26: device ref sata on end
Also I'm not aware of using SATA for Brya as of right now
I remember that is HW compatible? Volteer has SATA, I can remove this if we have no plan to support it.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... File src/mainboard/google/brya/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/48139/10/src/mainboard/google/brya/... PS10, Line 26: device ref sata on end
I remember that is HW compatible? Volteer has SATA, I can remove this if we have no plan to support […]
Eh, we can turn it off later too, I don't think we were going to use SATA, but that could still change too I suppose.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48139
to look at the new patch set (#11).
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48139/11
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 11: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
Patch Set 12:
Thanks Eric !!
Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48139 )
Change subject: mb/google/brya: Initiate device tree ......................................................................
mb/google/brya: Initiate device tree
Initiate device tree based on latest schematic.
BUG=b:174266035 TEST=Build Test
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: Ia94119cb6d7eff6ea13c7d6a7dfd6ce891f706fd Reviewed-on: https://review.coreboot.org/c/coreboot/+/48139 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/brya/variants/baseboard/devicetree.cb 1 file changed, 37 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/brya/variants/baseboard/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/devicetree.cb index fbd7d72..479a7ee 100644 --- a/src/mainboard/google/brya/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/devicetree.cb @@ -2,4 +2,41 @@ device cpu_cluster 0 on device lapic 0 on end end + + device domain 0 on + device ref igpu on end + device ref dtt on end + device ref tbt_pcie_rp0 on end + device ref tbt_pcie_rp1 on end + device ref tbt_pcie_rp2 on end + device ref tcss_xhci on end + device ref tcss_dma0 on end + device ref tcss_dma1 on end + device ref cnvi_bt on end + device ref xhci on end + device ref shared_sram on end + device ref cnvi_wifi on + chip drivers/wifi/generic + register "wake" = "GPE0_PME_B0" + device generic 0 on end + end + end + device ref heci1 on end + device ref sata on end + device ref pcie_rp1 on end #USB3-1 Type A + device ref pcie_rp4 on end #USB3-4 WWAN + device ref pcie_rp5 on end #PCIE5 WLAN + device ref pcie_rp6 on end #PCIE6 WWAN + device ref pcie_rp8 on end #PCIE8 SD card + device ref pcie_rp9 on end #PCIE9-12 SSD + device ref uart0 on end + device ref gspi0 on end + device ref gspi1 on end + device ref pch_espi on + chip ec/google/chromeec + device pnp 0c09.0 on end + end + end + device ref hda on end + end end
-
EricR Lai (Code Review) -
Tim Wawrzynczak (Code Review)