Attention is currently required from: Julius Werner, Karthik Ramasubramanian, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86225?usp=email )
Change subject: vc/google/chromeos: Add low battery indicator screen ......................................................................
Patch Set 6:
(1 comment)
File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/86225/comment/71e65721_3bff740d?usp... : PS1, Line 128: Don't select if not sure.
Then maybe something like "Enable only if the platform support it" would be more helpful. […]
Based on my understanding, the `CHROMEOS_LOW_BATTERY_INDICATOR_SCREEN_EARLY` depends on the platform's capability to support an early sign-of-life indicator. However, it may not be essential to capture this dependency explicitly with a `HAVE_` Kconfig option. This feature pertains to a Chrome OS driver, which should be enabled through the board definition. Since the board definition is intrinsically linked to a specific platform, it is already cognizant of the platform's capabilities. Nonetheless, I would advise incorporating explanatory text in the help section to clarify this dependency for better understanding.
-
Jérémy Compostella (Code Review)