Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25344 )
Change subject: ACPI: Add SPCR table ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c File src/arch/x86/acpi.c:
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c@1534 PS6, Line 1534: Create the Serial Port Console Redirection Ta update comment to indicate that this returning the SPCR encoded baudrate
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c@1562 PS6, Line 1562: acpi_header_t *header = &(spcr->header); : uint8_t baud; nit: these should really be at the start of the function before the if()
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c@1603 PS6, Line 1603: (void * argument type is u8*
https://review.coreboot.org/#/c/25344/6/src/arch/x86/acpi.c@1605 PS6, Line 1605: (void *) should not need to cast to void *