Attention is currently required from: Sumeet R Pawnikar. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54098 )
Change subject: ec/google/chromeec: OEM variables support for DPTF ......................................................................
Patch Set 1:
(3 comments)
File src/ec/google/chromeec/ec_dptf_helpers.c:
https://review.coreboot.org/c/coreboot/+/54098/comment/bfd003f0_c16af6b9 PS1, Line 135: ODVP Same comment as below.
https://review.coreboot.org/c/coreboot/+/54098/comment/31384b78_1ce31356 PS1, Line 136: acpigen_pop_len(); Can you please add a comment regarding which scope you are trying to pop? Also shouldn't this be done before generating the notification or does it not matter?
https://review.coreboot.org/c/coreboot/+/54098/comment/037e1045_8bee3463 PS1, Line 300: ODVE Besides Tim's comment below, the method name is mentioned as ODVP in BWG.