Attention is currently required from: YH Lin, Paul Menzel, Tim Wawrzynczak.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62954 )
Change subject: mb/google/brya/var/taeko: Add new FW_CONFIG option for THERMAL
......................................................................
Patch Set 6:
(2 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/62954/comment/506262b4_88901e8f
PS3, Line 7: mb/google/brya/var/taeko:Add
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/62954/comment/b58c33e0_c4eedbc6
PS3, Line 9: tarlo
- What is tarlo? Should it be mentioned in the summary? […]
1.Tarlo is a project which uses the same fw with taeko, I have updated the commit message to prevent misunderstanding.
2. These values are provided by LCFC thermal team. Please see issue tracker for more details.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62954
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37f79cde502115bbf65bb97216eddb6ea22b1648
Gerrit-Change-Number: 62954
Gerrit-PatchSet: 6
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jerry2 Huang
jerry2.huang@lcfc.corp-partner.google.com
Gerrit-CC: Kevin Chang
kevin.chang@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rasheed Hsueh
rasheed.hsueh@lcfc.corp-partner.google.com
Gerrit-CC: Sunshine Chao
sunshine.chao@lcfc.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Tue, 22 Mar 2022 05:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment