Attention is currently required from: Balázs Vinarz, HacX Scedix, Kyösti Mälkki, Martin L Roth, Paul Menzel, Vlado Ilic, awokd@danwin1210.me.
Hello Balázs Vinarz, HacX Scedix, Martin L Roth, Paul Menzel, Vlado Ilic, awokd@danwin1210.me, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/76832?usp=email
to look at the new patch set (#11).
The following approvals got outdated and were removed: Verified+1 by build bot (Jenkins)
Change subject: util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards ......................................................................
util/scripts/restore_agesa.sh - restores the opensource AMD AGESA boards
restore_agesa.sh reverts the opensource AGESA AMD boards removal that happened after 5e8e911b7caee021faff96c4e82a77a42544ea62 (0 point of history, or 0 PoH) - by git-reverting: 1) the "bad commits" (marked as "CBF" = coreboot build failure) - that either remove or break a code needed for our boards 2) the "unlucky commits" (marked as "GRF" = git revert failure) - that are a roadblock for git-reverting the "bad commits"
Right now at 3329e8893eaef8637b3ebdcf3b46e8adcdb5539a (5448 PoH), it takes 43 CBF git reverts - just 1% of 5448 commits since the OSS AGESA removal! - - making this removal look questionable and the idea of restoration viable.
SUCCESSFUL TESTS for the opensource AGESA boards which I own (Lenovo G505S - - fam15 laptop, ASUS A88XM-E - fam15 desktop, ASUS AM1I-A - fam16 desktop): 1) only build: 69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for AM1I-A, most likely boot works too but I didn't have the time to test 2) build & boot: 786292a0fca78405d56afb3f97a88f17f1c4bd32 (5166 PoH) for G505S test only, 11ba8ebbcc662ebd1dc8e14372a020eb32f26561 (3741 PoH) for G505S test only, 69ffebf5ccf123bc0b3fb28b485985af0597761d (3698 PoH) for G505S and A88XM-E
Change-Id: Ib4658dcaf4ff6fbac36070529284f2c982ed73c3 Signed-off-by: Mike Banon mikebdp2@gmail.com --- A util/scripts/restore_agesa.sh 1 file changed, 267 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/76832/11