HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32950
Change subject: nb/northbridge/intel/x4x/acpi.c: Remove variable set but not used ......................................................................
nb/northbridge/intel/x4x/acpi.c: Remove variable set but not used
Change-Id: I715adbe3d90d0f5195b54c274fb7843945d3e6be Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/x4x/acpi.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/32950/1
diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c index fb04fd8..a91d227 100644 --- a/src/northbridge/intel/x4x/acpi.c +++ b/src/northbridge/intel/x4x/acpi.c @@ -25,11 +25,9 @@
unsigned long acpi_fill_mcfg(unsigned long current) { - struct device *dev; u32 pciexbar = 0; u32 length = 0;
- dev = pcidev_on_root(0, 0); if (!decode_pciebar(&pciexbar, &length)) return current;
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32950 )
Change subject: nb/northbridge/intel/x4x/acpi.c: Remove variable set but not used ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32950 )
Change subject: nb/northbridge/intel/x4x/acpi.c: Remove variable set but not used ......................................................................
nb/northbridge/intel/x4x/acpi.c: Remove variable set but not used
Change-Id: I715adbe3d90d0f5195b54c274fb7843945d3e6be Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/32950 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz --- M src/northbridge/intel/x4x/acpi.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Arthur Heymans: Looks good to me, approved
diff --git a/src/northbridge/intel/x4x/acpi.c b/src/northbridge/intel/x4x/acpi.c index fb04fd8..a91d227 100644 --- a/src/northbridge/intel/x4x/acpi.c +++ b/src/northbridge/intel/x4x/acpi.c @@ -25,11 +25,9 @@
unsigned long acpi_fill_mcfg(unsigned long current) { - struct device *dev; u32 pciexbar = 0; u32 length = 0;
- dev = pcidev_on_root(0, 0); if (!decode_pciebar(&pciexbar, &length)) return current;