Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42702 )
Change subject: nb/intel/ironlake: Drop copy-pasted and unused macro ......................................................................
nb/intel/ironlake: Drop copy-pasted and unused macro
Tested with BUILD_TIMELESS=1, packardbell/ms2290 remains identical.
Change-Id: I78856707864563e392626a494f0e77eec9802002 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/ironlake/finalize.c 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/42702/1
diff --git a/src/northbridge/intel/ironlake/finalize.c b/src/northbridge/intel/ironlake/finalize.c index 6e0844b..88bc98d 100644 --- a/src/northbridge/intel/ironlake/finalize.c +++ b/src/northbridge/intel/ironlake/finalize.c @@ -2,8 +2,6 @@
#include "ironlake.h"
-#define PCI_DEV_SNB PCI_DEV(0, 0, 0) - void intel_ironlake_finalize_smm(void) { MCHBAR32_OR(0x5500, 1 << 0); /* PAVP */
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42702 )
Change subject: nb/intel/ironlake: Drop copy-pasted and unused macro ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42702 )
Change subject: nb/intel/ironlake: Drop copy-pasted and unused macro ......................................................................
nb/intel/ironlake: Drop copy-pasted and unused macro
Tested with BUILD_TIMELESS=1, packardbell/ms2290 remains identical.
Change-Id: I78856707864563e392626a494f0e77eec9802002 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/42702 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/northbridge/intel/ironlake/finalize.c 1 file changed, 0 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/northbridge/intel/ironlake/finalize.c b/src/northbridge/intel/ironlake/finalize.c index 6e0844b..88bc98d 100644 --- a/src/northbridge/intel/ironlake/finalize.c +++ b/src/northbridge/intel/ironlake/finalize.c @@ -2,8 +2,6 @@
#include "ironlake.h"
-#define PCI_DEV_SNB PCI_DEV(0, 0, 0) - void intel_ironlake_finalize_smm(void) { MCHBAR32_OR(0x5500, 1 << 0); /* PAVP */
-
Angel Pons (Code Review) -
Patrick Georgi (Code Review)