Attention is currently required from: Tim Wawrzynczak, EricR Lai.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52185 )
Change subject: mb/google/brya: Add FPMCU power control
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
@Furquan, I can try to add new FPMCU driver, but here we have UART and SPI. […]
I posted a comment here: https://review.coreboot.org/c/coreboot/+/52181/comment/7357ab3f_150a962b/
I think we should do the same for brya. I know S3 isn't as critical on brya, but it would be good to keep the behavior consistent across S3 and S0ix.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a8fae80c3cc186e0a097ab2007abb656f382cbd
Gerrit-Change-Number: 52185
Gerrit-PatchSet: 1
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Thu, 08 Apr 2021 17:54:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment