Attention is currently required from: Jason Nien, EricKY Cheng, Chris Wang, Martin Roth, Eric Peers, Karthikeyan Ramasubramanian.
Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68472 )
Change subject: mb/google/skyrim/var/winterhold: update thermal config
......................................................................
Patch Set 31: Code-Review+1
(1 comment)
File src/mainboard/google/skyrim/variants/winterhold/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/68472/comment/360f7778_ded67faf
PS31, Line 7: # Refer the spec "FT6 Infrastructure Roadmap"#57316
: # Set system_configuration to 4 for 15W
: register "system_configuration" = "4"
Base on CB:69904, I found below are the same with baseboard settings. Will you remove it later or on this CL?
```
system_configuration
fast_ppt_limit_mW
sustained_power_limit_mW
vrm_current_limit_mA
vrm_maximum_current_limit_mA
vrm_soc_current_limit_mA
vrm_current_limit_throttle_mA
vrm_maximum_current_limit_throttle_mA
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68472
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie0740cb5bb16cd53c2ee6937e32a974346012823
Gerrit-Change-Number: 68472
Gerrit-PatchSet: 31
Gerrit-Owner: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nelson Ye
nelson_ye@compal.corp-partner.google.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: EricKY Cheng
ericky_cheng@compal.corp-partner.google.com
Gerrit-Attention: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Eric Peers
epeers@google.com
Gerrit-Attention: Karthikeyan Ramasubramanian
kramasub@chromium.org
Gerrit-Comment-Date: Fri, 02 Dec 2022 09:24:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment