Change in coreboot[master]: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 2 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/1
diff --git a/src/soc/intel/icelake/bootblock/bootblock.c b/src/soc/intel/icelake/bootblock/bootblock.c index 6bf1e13..9aa6fb4 100644 --- a/src/soc/intel/icelake/bootblock/bootblock.c +++ b/src/soc/intel/icelake/bootblock/bootblock.c @@ -2,12 +2,8 @@ /* This file is part of the coreboot project. */
#include <bootblock_common.h> -#include <intelblocks/gspi.h> -#include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> -#include <soc/iomap.h> -#include <soc/pch.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { @@ -21,6 +17,7 @@ bootblock_pch_early_init(); bootblock_cpu_init(); pch_early_iorange_init(); + if (CONFIG(INTEL_LPSS_UART_FOR_CONSOLE)) uart_bootblock_init(); } diff --git a/src/soc/intel/jasperlake/bootblock/bootblock.c b/src/soc/intel/jasperlake/bootblock/bootblock.c index 6bf1e13..f7ec0e8 100644 --- a/src/soc/intel/jasperlake/bootblock/bootblock.c +++ b/src/soc/intel/jasperlake/bootblock/bootblock.c @@ -2,12 +2,8 @@ /* This file is part of the coreboot project. */
#include <bootblock_common.h> -#include <intelblocks/gspi.h> -#include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> -#include <soc/iomap.h> -#include <soc/pch.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { diff --git a/src/soc/intel/skylake/bootblock/bootblock.c b/src/soc/intel/skylake/bootblock/bootblock.c index 15f250d..2844571 100644 --- a/src/soc/intel/skylake/bootblock/bootblock.c +++ b/src/soc/intel/skylake/bootblock/bootblock.c @@ -2,7 +2,6 @@ /* This file is part of the coreboot project. */
#include <bootblock_common.h> -#include <drivers/i2c/designware/dw_i2c.h> #include <intelblocks/gspi.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> diff --git a/src/soc/intel/tigerlake/bootblock/bootblock.c b/src/soc/intel/tigerlake/bootblock/bootblock.c index 6bf1e13..9aa6fb4 100644 --- a/src/soc/intel/tigerlake/bootblock/bootblock.c +++ b/src/soc/intel/tigerlake/bootblock/bootblock.c @@ -2,12 +2,8 @@ /* This file is part of the coreboot project. */
#include <bootblock_common.h> -#include <intelblocks/gspi.h> -#include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> -#include <soc/iomap.h> -#include <soc/pch.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { @@ -21,6 +17,7 @@ bootblock_pch_early_init(); bootblock_cpu_init(); pch_early_iorange_init(); + if (CONFIG(INTEL_LPSS_UART_FOR_CONSOLE)) uart_bootblock_init(); }
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#2).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20: Huh?
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h> Um...
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20: Er...
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20:
Huh?
pch_early_iorange_init() ? <soc/bootblock.h>
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Um...
Ack
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#5).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
Also add missing <intelblocks/systemagent.h>
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/5
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 5:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20:
pch_early_iorange_init() ? […]
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Ack
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20:
Er...
I don't understand...
'bootblock_systemagent_early_init()' is here: <soc/bootblock.h> 'bootblock_pch_early_init()' is here: <soc/bootblock.h> 'bootblock_cpu_init()' is here: <soc/bootblock.h> 'pch_early_iorange_init()' is also here: <soc/bootblock.h>
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#6).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 3 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/6
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 7:
(3 comments)
Sorry, I should have been more verbose
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20:
Done
Why did you add a space?
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Done
Please mention this in the commit message
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20:
I don't understand... […]
Why did you add a space?
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#8).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/8
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 8:
(1 comment)
Thx
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20:
Why did you add a space?
mistake on rebase ... thx
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... File src/soc/intel/icelake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/icelake/bootb... PS4, Line 20:
Why did you add a space?
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Please mention this in the commit message
Done
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... File src/soc/intel/tigerlake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/tigerlake/boo... PS4, Line 20:
mistake on rebase ... […]
Done
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 8: Code-Review+2
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 8: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 8: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Done
Got lost in a rebase
Hello build bot (Jenkins), Wonkyu Kim, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#9).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes
Also add missing <intelblocks/systemagent.h>
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/9
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/bootblock.c:
https://review.coreboot.org/c/coreboot/+/40689/4/src/soc/intel/skylake/bootb... PS4, Line 4: #include <intelblocks/systemagent.h>
Got lost in a rebase
Thank you Done
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Drop unused includes ......................................................................
Patch Set 10: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40689/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40689/10//COMMIT_MSG@7 PS10, Line 7: Drop unused nit: I'd say "Clean up includes" here, and state in the commit message:
Drop unused includes and add missing <intelblocks/systemagent.h>
Hello build bot (Jenkins), Wonkyu Kim, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#11).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes
Drop unused includes and add missing <intelblocks/systemagent.h>
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/11
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes ......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40689/10//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40689/10//COMMIT_MSG@7 PS10, Line 7: Drop unused
nit: I'd say "Clean up includes" here, and state in the commit message: […]
Thank you.
Hello build bot (Jenkins), Wonkyu Kim, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40689
to look at the new patch set (#12).
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes
Drop unused includes and add missing <intelblocks/systemagent.h>.
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 1 insertion(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/89/40689/12
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes ......................................................................
{icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes
Drop unused includes and add missing <intelblocks/systemagent.h>.
Change-Id: I06c8b2bf65283c3c1fcd25fdaae298b82fc0e09c Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40689 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com --- M src/soc/intel/icelake/bootblock/bootblock.c M src/soc/intel/jasperlake/bootblock/bootblock.c M src/soc/intel/skylake/bootblock/bootblock.c M src/soc/intel/tigerlake/bootblock/bootblock.c 4 files changed, 1 insertion(+), 10 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Wonkyu Kim: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/icelake/bootblock/bootblock.c b/src/soc/intel/icelake/bootblock/bootblock.c index ce71cdd..54ad85a 100644 --- a/src/soc/intel/icelake/bootblock/bootblock.c +++ b/src/soc/intel/icelake/bootblock/bootblock.c @@ -1,12 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <intelblocks/gspi.h> #include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> -#include <soc/iomap.h> -#include <soc/pch.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { diff --git a/src/soc/intel/jasperlake/bootblock/bootblock.c b/src/soc/intel/jasperlake/bootblock/bootblock.c index ce71cdd..54ad85a 100644 --- a/src/soc/intel/jasperlake/bootblock/bootblock.c +++ b/src/soc/intel/jasperlake/bootblock/bootblock.c @@ -1,12 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <intelblocks/gspi.h> #include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> -#include <soc/iomap.h> -#include <soc/pch.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) { diff --git a/src/soc/intel/skylake/bootblock/bootblock.c b/src/soc/intel/skylake/bootblock/bootblock.c index 461e28c..6380db2 100644 --- a/src/soc/intel/skylake/bootblock/bootblock.c +++ b/src/soc/intel/skylake/bootblock/bootblock.c @@ -1,7 +1,7 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <drivers/i2c/designware/dw_i2c.h> +#include <intelblocks/systemagent.h> #include <intelblocks/gspi.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> diff --git a/src/soc/intel/tigerlake/bootblock/bootblock.c b/src/soc/intel/tigerlake/bootblock/bootblock.c index ce71cdd..54ad85a 100644 --- a/src/soc/intel/tigerlake/bootblock/bootblock.c +++ b/src/soc/intel/tigerlake/bootblock/bootblock.c @@ -1,12 +1,9 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <bootblock_common.h> -#include <intelblocks/gspi.h> #include <intelblocks/systemagent.h> #include <intelblocks/uart.h> #include <soc/bootblock.h> -#include <soc/iomap.h> -#include <soc/pch.h>
asmlinkage void bootblock_c_entry(uint64_t base_timestamp) {
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40689 )
Change subject: {icelake,jasperlake,skylake,tigerlake}/bootblock.c: Clean up includes ......................................................................
Patch Set 13:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4568 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4567 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4566 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4565
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)
-
Wonkyu Kim (Code Review)