Attention is currently required from: Bao Zheng, Fred Reitberger, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81137?usp=email )
Change subject: amdfwtool: Remove the dissociated combo BIOS table for recovery A/B
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/81137/comment/3a1a8117_2d07ae3f :
PS2, Line 1732: } else if (bhd_combo_dir != NULL) {
i wonder if it would be better to check for !cb_config.recovery_ab here. if you prefer to check for bhd_combo_dir != NULL, please add a comment that this is the !cb_config.recovery_ab case
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81137?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8735bd91b32bc9a0e4fc70d293e8d836d5e9c36b
Gerrit-Change-Number: 81137
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 13:11:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment