Matt DeVillier has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40119 )
Change subject: mb/google/rambi: use ACPI backlight controls ......................................................................
mb/google/rambi: use ACPI backlight controls
All variants except NINJA have a built-in display. Enables ACPI brightness controls under Windows.
Change-Id: I8dd026608de606fa33f28ccb2967f3beb83b3470 Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/google/rambi/devicetree.cb M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/rambi/variants/ninja/overridetree.cb 3 files changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/40119/1
diff --git a/src/mainboard/google/rambi/devicetree.cb b/src/mainboard/google/rambi/devicetree.cb index dc11ec8..c7bc0b6 100644 --- a/src/mainboard/google/rambi/devicetree.cb +++ b/src/mainboard/google/rambi/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/baytrail
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + # SATA port enable mask (2 ports) register "sata_port_map" = "0x1" register "sata_ahci" = "0x1" diff --git a/src/mainboard/google/rambi/dsdt.asl b/src/mainboard/google/rambi/dsdt.asl index 3a8d1a1..347269f 100644 --- a/src/mainboard/google/rambi/dsdt.asl +++ b/src/mainboard/google/rambi/dsdt.asl @@ -36,6 +36,7 @@ { //#include <soc/intel/baytrail/acpi/northcluster.asl> #include <soc/intel/baytrail/acpi/southcluster.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
/* Dynamic Platform Thermal Framework */ diff --git a/src/mainboard/google/rambi/variants/ninja/overridetree.cb b/src/mainboard/google/rambi/variants/ninja/overridetree.cb index 3f67644..47527da 100644 --- a/src/mainboard/google/rambi/variants/ninja/overridetree.cb +++ b/src/mainboard/google/rambi/variants/ninja/overridetree.cb @@ -1,5 +1,8 @@ chip soc/intel/baytrail
+ # No Built-in IGD Display + register "gfx.ndid" = "0" + register "usb2_comp_bg" = "0x4700"
# Allow PCIe devices to wake system from suspend
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40119 )
Change subject: mb/google/rambi: use ACPI backlight controls ......................................................................
Patch Set 1: Code-Review+2
Nice
Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40119 )
Change subject: mb/google/rambi: use ACPI backlight controls ......................................................................
mb/google/rambi: use ACPI backlight controls
All variants except NINJA have a built-in display. Enables ACPI brightness controls under Windows.
Change-Id: I8dd026608de606fa33f28ccb2967f3beb83b3470 Signed-off-by: Matt DeVillier matt.devillier@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40119 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/google/rambi/devicetree.cb M src/mainboard/google/rambi/dsdt.asl M src/mainboard/google/rambi/variants/ninja/overridetree.cb 3 files changed, 7 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/google/rambi/devicetree.cb b/src/mainboard/google/rambi/devicetree.cb index dc11ec8..c7bc0b6 100644 --- a/src/mainboard/google/rambi/devicetree.cb +++ b/src/mainboard/google/rambi/devicetree.cb @@ -1,5 +1,8 @@ chip soc/intel/baytrail
+ # IGD Displays + register "gfx" = "GMA_STATIC_DISPLAYS(0)" + # SATA port enable mask (2 ports) register "sata_port_map" = "0x1" register "sata_ahci" = "0x1" diff --git a/src/mainboard/google/rambi/dsdt.asl b/src/mainboard/google/rambi/dsdt.asl index 3a8d1a1..347269f 100644 --- a/src/mainboard/google/rambi/dsdt.asl +++ b/src/mainboard/google/rambi/dsdt.asl @@ -36,6 +36,7 @@ { //#include <soc/intel/baytrail/acpi/northcluster.asl> #include <soc/intel/baytrail/acpi/southcluster.asl> + #include <drivers/intel/gma/acpi/default_brightness_levels.asl> }
/* Dynamic Platform Thermal Framework */ diff --git a/src/mainboard/google/rambi/variants/ninja/overridetree.cb b/src/mainboard/google/rambi/variants/ninja/overridetree.cb index 3f67644..47527da 100644 --- a/src/mainboard/google/rambi/variants/ninja/overridetree.cb +++ b/src/mainboard/google/rambi/variants/ninja/overridetree.cb @@ -1,5 +1,8 @@ chip soc/intel/baytrail
+ # No Built-in IGD Display + register "gfx.ndid" = "0" + register "usb2_comp_bg" = "0x4700"
# Allow PCIe devices to wake system from suspend
-
Angel Pons (Code Review) -
Matt DeVillier (Code Review)