Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59843 )
Change subject: libpayload/Makefile: Improve object files list creation
......................................................................
Patch Set 1:
(2 comments)
File payloads/libpayload/Makefile:
https://review.coreboot.org/c/coreboot/+/59843/comment/e2d80efb_73769d14
PS1, Line 322: # $1 lib name
the toplevel Makefile uses "stage name" here. Potential follow up: change both to call it "class name" as that's the generic name for that.
https://review.coreboot.org/c/coreboot/+/59843/comment/0f95891e_4a697cb1
PS1, Line 373: cscope -bR -s$(coreboottop)/src/commonlib/bsd
This seems to be unrelated?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59843
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If1280c0a3f7e99aad2ecf8a0379a98af31ccefc3
Gerrit-Change-Number: 59843
Gerrit-PatchSet: 1
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Jan Dabros
jsd@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
patrick@coreboot.org
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Jan Dabros
jsd@semihalf.com
Gerrit-Comment-Date: Mon, 06 Dec 2021 08:34:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment