Attention is currently required from: Avi Uday, Kapil Porwal, Nick Vaccaro, Pranava Y N.
Subrata Banik has posted comments on this change by Avi Uday. ( https://review.coreboot.org/c/coreboot/+/87351?usp=email )
Change subject: mb/google/ocelot: Update Ocelot board ......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/ocelot/Kconfig:
https://review.coreboot.org/c/coreboot/+/87351/comment/aada92ee_79d4d422?usp... : PS4, Line 65: empty line ?
https://review.coreboot.org/c/coreboot/+/87351/comment/32dccc76_40d22417?usp... : PS4, Line 66: select EC_GOOGLE_CHROMEEC_MEC : select MAINBOARD_USES_IFD_EC_REGION please check with Ocelet SKU matrix and find out if we need to support MEC EC chip or not ? otherwise we may decide to drop these Kconfigs
File src/mainboard/google/ocelot/variants/ocelot/fw_config.c:
https://review.coreboot.org/c/coreboot/+/87351/comment/f8fd4800_0a9b0a7d?usp... : PS4, Line 343: >>>>>>> 8b036f22cc (mb/google/ocelot: Update Ocelot board)
`spaces required around that ':' (ctx:VxW)`
Please fix.
File src/mainboard/google/ocelot/variants/ocelot/fw_config.c:
https://review.coreboot.org/c/coreboot/+/87351/comment/0d704395_3406fe61?usp... : PS5, Line 608: TOUCHSCREEN_GSPI can you please check if this code is buildable ? mostly not so, because CB:87310 has dropped TOUCHSCREEN_GSPI but you are still using it