Attention is currently required from: Gavin Liu, Hung-Te Lin.
Yu-Ping Wu has posted comments on this change by Gavin Liu. ( https://review.coreboot.org/c/coreboot/+/86252?usp=email )
Change subject: soc/mediatek/mt8196: Add TF-A static library path
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/mt8196/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/86252/comment/8520f132_1632afcb?usp... :
PS1, Line 96: libmtk.a
We only need `lib` prefix. We can rename it to `libbl31.a` or `libtf-a. […]
I like libbl31, as it's more consistent with BL31_MAKEARGS. libmtk is a too general name.
Regarding the tf-a patch, the chromiumos ebuild can rename the file, if you don't want to modify the patch.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86252?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I858686ede3730fb70f71565ca3593e7eb4c460d2
Gerrit-Change-Number: 86252
Gerrit-PatchSet: 2
Gerrit-Owner: Gavin Liu
gavin.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Gavin Liu
gavin.liu@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Mon, 03 Feb 2025 13:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Gavin Liu
gavin.liu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com