Attention is currently required from: Angel Pons, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Jingyuan Liang, Kapil Porwal, Kyoung Il Kim, Paul Menzel, Subrata Banik, Tarun.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81333?usp=email )
Change subject: mb/google/rex: Add Intel Touch for controller 1 for Rex ......................................................................
Patch Set 6:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81333/comment/cc9a75ad_ddb3123c : PS4, Line 13: Major rework is required for Rex P1 and P2.
Why? What is the problem with the current implementation?
THC was not part of feature in Rex. The THC GPIO pads are not routed the touch device and some of these THC GPIO pads is configured for different devices. In EVT, we changes some of pad routing such that we only need to stuff/un-stuff registers to switch to THC device connection.
https://review.coreboot.org/c/coreboot/+/81333/comment/50d2cbc1_d83a067f : PS4, Line 9: GPIO pad configuration for THC1 according to CBI fw_config. : ACPI entries in SSDT for ELAN according to CBI fw_config. : : THC0 must be enabled when THC1 is enabled. : Major rework is required for Rex P1 and P2. minor Rework is needed for : EVT. Rex with THC rework won't be able to support UWB and FPCMU. : The touch device must be converted to SPI interface. : When THC is enabled and the THC rework is in place, the UWB and FPMCU : are not supported and need to be disable from the CBI. : THC0 will also be provided with ACPI entries when THC1 is enabled. : THC1 GPIO pins will be configured for THC according to the CBI : TOUCHSCREEN fw_config field. : The resistor on the THC-SPI MISO pin should be 100 Ohm.
For me this reads very heard, as you break the line after every sentence, and often it’s also just a […]
ok. let me make changes.
File src/mainboard/google/rex/variants/rex0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/81333/comment/97906fa8_faa333d5 : PS2, Line 33: THC NOTE for P1 and P2:reworked
Please add a space after the colon.
Done