Attention is currently required from: Felix Held, Martin Roth.
Varshit Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78220?usp=email )
Change subject: soc/amd/genoa: Add GPIO definitions ......................................................................
Patch Set 7:
(4 comments)
File src/soc/amd/genoa/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/78220/comment/6360475d_ec5b43df : PS6, Line 146: GPIO_26_IOMUX_PCIE_RST_L
GPIO_26_IOMUX_PCIE_RST1_L -> the 1 is missing there
Done
https://review.coreboot.org/c/coreboot/+/78220/comment/4dc3b322_37f1bda5 : PS6, Line 192: #define GPIO_126_IOMUX_ESPI_CS2_L 0
GPIO_126_IOMUX_SPI_CS2_L -> that's for spi and not espi
Done
https://review.coreboot.org/c/coreboot/+/78220/comment/0abbbd67_971567c3 : PS6, Line 252: #define GPIO_257_IOMUX_SGPIO1_CLK 1
GPIO_257_IOMUX_CLK_REQ01_L for gpio mux = 2 is missing
Done
https://review.coreboot.org/c/coreboot/+/78220/comment/dd9e8538_e69d03d6 : PS6, Line 254: #define GPIO_258_IOMUX_SGPIO2_CLK 1
GPIO_258_IOMUX_CLK_REQ02_L for gpio mux == 2 is missing
Done