Attention is currently required from: Elyes Haouas.
Nico Huber has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/82658?usp=email )
Change subject: tree: Use Wcalloc-transposed-args command option ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
This breaks building with GCC 13.2. The commit message does not mention this at all. […]
Same here, such things belong into xcompile. And it's part of `-Wextra` btw. which is a far more portable option (I just tried, it even adds important warnings that we haven't enabled atm. e.g. `-Wsign-compare`).
Why do we bother with warnings about cosmetics that break compatibility when we don't use the imortant ones??? This is pretty pointless, please revert. Once we can enable -Wextra (some of the options we would want to discuss / opt-out), we'll get this for free.
-
Nico Huber (Code Review)