Change in coreboot[master]: mb/siemens/mc_apl6: Add TPM to devicetree

[Werner Zeh (Code Review)]

Werner Zeh has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36677 )

Change subject: mb/siemens/mc_apl6: Add TPM to devicetree
......................................................................

mb/siemens/mc_apl6: Add TPM to devicetree

The TPM chip needs to be added to the devicetree so that the ACPI tables
will be generated for it. These ACPI table entry is used by the OS to get
the location of the TPM chip.

Change-Id: Ic40d1cf236dd849f04f088808d94b6dd81e3238a
Signed-off-by: Werner Zeh 
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
1 file changed, 5 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36677/1

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
index 6c18db9..03bf7dd 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
@@ -101,7 +101,11 @@
    	device pci 1c.0 off end	# - eMMC
    	device pci 1d.0 off end	# - UFS
    	device pci 1e.0 off end	# - SDIO
-		device pci 1f.0 on  end	# - LPC
+		device pci 1f.0 on  	# - LPC
+			chip drivers/pc80/tpm
+				device pnp 0c31.0 on end
+			end
+		end
    	device pci 1f.1 on  end	# - SMBUS
    end
 end

[Mario Scheithauer (Code Review)]

Mario Scheithauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36677 )

Change subject: mb/siemens/mc_apl6: Add TPM to devicetree
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36677 )

Change subject: mb/siemens/mc_apl6: Add TPM to devicetree
......................................................................

mb/siemens/mc_apl6: Add TPM to devicetree

The TPM chip needs to be added to the devicetree so that the ACPI tables
will be generated for it. These ACPI table entry is used by the OS to get
the location of the TPM chip.

Change-Id: Ic40d1cf236dd849f04f088808d94b6dd81e3238a
Signed-off-by: Werner Zeh 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/36677
Tested-by: build bot (Jenkins) 
Reviewed-by: Mario Scheithauer 
---
M src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  build bot (Jenkins): Verified
  Mario Scheithauer: Looks good to me, approved

diff --git a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
index 17b7fac..e12972c 100644
--- a/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
+++ b/src/mainboard/siemens/mc_apl1/variants/mc_apl6/devicetree.cb
@@ -69,7 +69,11 @@
    	device pci 1c.0 off end	# - eMMC
    	device pci 1d.0 off end	# - UFS
    	device pci 1e.0 off end	# - SDIO
-		device pci 1f.0 on  end	# - LPC
+		device pci 1f.0 on  	# - LPC
+			chip drivers/pc80/tpm
+				device pnp 0c31.0 on end
+			end
+		end
    	device pci 1f.1 on  end	# - SMBUS
    end
 end