Change in coreboot[master]: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27585 )
Change subject: cpu/intel/smm/gen1: Use correct MSR for model_6fx and model_1067x ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c File src/cpu/intel/smm/gen1/smmrelocate.c:
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c... PS1, Line 72: if (!((msr.lo & (1 << 3)) && (msr.lo & (1 <<0)))) { need consistent spacing around '<<' (ctx:WxV)
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c... PS1, Line 158: /* for model_6fx and model_1067x byte [0:11] on smrr_base are reserved */ line over 80 characters
https://review.coreboot.org/#/c/27585/1/src/cpu/intel/smm/gen1/smmrelocate.c... PS1, Line 163: params->smrr_base.lo = (params->smram_base & rmask) | MTRR_TYPE_WRBACK; line over 80 characters
-
build bot (Jenkins) (Code Review)