Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/1
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index 79f26f2..82271e3 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -18,6 +18,11 @@
# End : OPN Performance Configuration
+ register "telemetry_vddcr_vdd_slope" = "30231" #mA + register "telemetry_vddcr_vdd_offset" = "0-1" + register "telemetry_vddcr_soc_slope" = "22644" #mA + register "telemetry_vddcr_soc_offset" = "68" + # I2C2 for touchscreen and trackpad register "i2c[2]" = "{ .speed = I2C_SPEED_FAST,
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43278/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/2/src/mainboard/google/zork/v... PS2, Line 22: 0-1" Is this supposed to be -1?
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43278/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/2/src/mainboard/google/zork/v... PS2, Line 22: 0-1"
Is this supposed to be -1?
sorry it's from 0 to 1, so "0-1", this CL in my local env and build no problem
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 3:
(1 comment)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/43278/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/3/src/mainboard/google/zork/v... PS3, Line 16: 2500 1400
chris wang has uploaded a new patch set (#4) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/4
chris wang has uploaded a new patch set (#5) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/5
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 5: Code-Review+2
chris wang has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Removed Code-Review+2 by chris wang Chris.Wang@amd.com
chris wang has uploaded a new patch set (#6) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 44 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/6
chris wang has uploaded a new patch set (#7) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/7
chris wang has uploaded a new patch set (#8) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/8
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43278/8/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/8/src/mainboard/google/zork/v... PS8, Line 23: trailing whitespace
chris wang has uploaded a new patch set (#9) to the change originally created by Peichao Li. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/78/43278/9
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43278/9/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/9/src/mainboard/google/zork/v... PS9, Line 24: - Presumably the fields should not be unsigned since we can have negative values. Probably worth a clean up.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43278/2/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/2/src/mainboard/google/zork/v... PS2, Line 22: 0-1"
I don't think it is possible to support "range" here. IIUC, this would evaluate to -1.
Done
https://review.coreboot.org/c/coreboot/+/43278/3/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/3/src/mainboard/google/zork/v... PS3, Line 16: 2500
1400
Ack
Aaron Durbin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz ......................................................................
mb/google/vilboz: update telemetry settings for vilboz
update telemetry value for SDLE test result.
BUG=b:160698427 BRANCH=None TEST=emerge-zork coreboot
Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf Signed-off-by: Chris Wang chris.wang@amd.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/43278 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Aaron Durbin adurbin@chromium.org --- M src/mainboard/google/zork/variants/vilboz/overridetree.cb 1 file changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved
diff --git a/src/mainboard/google/zork/variants/vilboz/overridetree.cb b/src/mainboard/google/zork/variants/vilboz/overridetree.cb index f9b7077..fe39d7c 100644 --- a/src/mainboard/google/zork/variants/vilboz/overridetree.cb +++ b/src/mainboard/google/zork/variants/vilboz/overridetree.cb @@ -18,6 +18,11 @@
# End : OPN Performance Configuration
+ register "telemetry_vddcr_vdd_slope" = "32453" #mA + register "telemetry_vddcr_vdd_offset" = "168" + register "telemetry_vddcr_soc_slope" = "22644" #mA + register "telemetry_vddcr_soc_offset" = "-70" + # USB OC pin mapping register "usb_port_overcurrent_pin[1]" = "USB_OC_NONE" # LTE instead of USB C1
-
Aaron Durbin (Code Review) -
build bot (Jenkins) (Code Review)
-
chris wang (Code Review)
-
Furquan Shaikh (Code Review)
-
Peichao Li (Code Review)