Matt DeVillier has submitted this change. ( https://review.coreboot.org/c/coreboot/+/77200?usp=email )
Change subject: mb/starlabs/starbook/rpl: Fix the Thunderbolt cmos option ......................................................................
mb/starlabs/starbook/rpl: Fix the Thunderbolt cmos option
For Thunderbolt to be disabled, `UsbTcPortEn` and `TcssXhciEn` also need to be disabled.
Change-Id: Ie02c1e0ea7583bbd78e25c8184e2cdf2b6281741 Signed-off-by: Sean Rhodes sean@starlabs.systems Reviewed-on: https://review.coreboot.org/c/coreboot/+/77200 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/starlabs/starbook/variants/rpl/Makefile.inc A src/mainboard/starlabs/starbook/variants/rpl/ramstage.c M src/mainboard/starlabs/starbook/variants/rpl/romstage.c 3 files changed, 13 insertions(+), 0 deletions(-)
Approvals: Matt DeVillier: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/mainboard/starlabs/starbook/variants/rpl/Makefile.inc b/src/mainboard/starlabs/starbook/variants/rpl/Makefile.inc index 2a505c3..9abc069 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/Makefile.inc +++ b/src/mainboard/starlabs/starbook/variants/rpl/Makefile.inc @@ -7,3 +7,4 @@ ramstage-y += devtree.c ramstage-y += gpio.c ramstage-y += hda_verb.c +ramstage-y += ramstage.c diff --git a/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c b/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c new file mode 100644 index 0000000..bd3d7ed --- /dev/null +++ b/src/mainboard/starlabs/starbook/variants/rpl/ramstage.c @@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ + +#include <option.h> +#include <soc/ramstage.h> + + +void mainboard_silicon_init_params(FSP_S_CONFIG *supd) +{ + if (get_uint_option("thunderbolt", 1) == 0) + supd->UsbTcPortEn = 0; +} diff --git a/src/mainboard/starlabs/starbook/variants/rpl/romstage.c b/src/mainboard/starlabs/starbook/variants/rpl/romstage.c index e51bd53..e7e1c6a 100644 --- a/src/mainboard/starlabs/starbook/variants/rpl/romstage.c +++ b/src/mainboard/starlabs/starbook/variants/rpl/romstage.c @@ -40,6 +40,7 @@ mupd->FspmConfig.VtdBaseAddress[3] = 0; mupd->FspmConfig.TcssDma0En = 0; mupd->FspmConfig.TcssItbtPcie0En = 0; + mupd->FspmConfig.TcssXhciEn = 0; }
mupd->FspmConfig.DmiMaxLinkSpeed = 4;