build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25105 )
Change subject: drivers/spi: Winbond specific write-protection enable ......................................................................
Patch Set 6:
(4 comments)
https://review.coreboot.org/#/c/25105/6/src/drivers/spi/winbond.c File src/drivers/spi/winbond.c:
https://review.coreboot.org/#/c/25105/6/src/drivers/spi/winbond.c@39 PS6, Line 39: #define CMD_VOLTILE_SREG_WREN 0x50 /* Write Enable for Volatile Status Register */ line over 80 characters
https://review.coreboot.org/#/c/25105/6/src/drivers/spi/winbond.c@82 PS6, Line 82: u8 : 5; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/#/c/25105/6/src/drivers/spi/winbond.c@84 PS6, Line 84: u8 : 1; space prohibited before that ':' (ctx:WxW)
https://review.coreboot.org/#/c/25105/6/src/drivers/spi/winbond.c@568 PS6, Line 568: "0x%08zx-0x%08zx\n",region->offset, region->size); space required after that ',' (ctx:VxV)